Use alternative method to set S variable. Quote variables. Use more standard ebuild functions. Die when appropriate. Do not install INSTALL or LICENSE. Remove obvious configuration suggestion.

Package-Manager: portage-2.2.0_alpha51/cvs/Linux x86_64

3 files changed, 63 insertions, 5 deletions

diff --git a/net-firewall/gshield/ChangeLog b/net-firewall/gshield/ChangeLog
index 0a20606283b0..dddf34362985 100644
--- a/net-firewall/gshield/ChangeLog
+++ b/net-firewall/gshield/ChangeLog
@@ -1,6 +1,13 @@
 # ChangeLog for net-firewall/gshield
 # Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/net-firewall/gshield/ChangeLog,v 1.9 2011/08/20 20:34:16 jer Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-firewall/gshield/ChangeLog,v 1.10 2011/08/20 21:03:53 jer Exp $
+
+*gshield-2.8-r3 (20 Aug 2011)
+
+  20 Aug 2011; Jeroen Roovers <jer@gentoo.org> +gshield-2.8-r3.ebuild:
+  Use alternative method to set S variable. Quote variables. Use more standard
+  ebuild functions. Die when appropriate. Do not install INSTALL or LICENSE.
+  Remove obvious configuration suggestion.
 
   20 Aug 2011; Jeroen Roovers <jer@gentoo.org> metadata.xml:
   Remove useless maintainer tag.
diff --git a/net-firewall/gshield/Manifest b/net-firewall/gshield/Manifest
index 6480280c5111..36654ccd6aa9 100644
--- a/net-firewall/gshield/Manifest
+++ b/net-firewall/gshield/Manifest
@@ -4,12 +4,13 @@ Hash: SHA1
 AUX gshield.init 648 RMD160 ab47b0c2a4f698fafe43ddf10aa15fc30122de3c SHA1 775236f7275072a27ae526935762b3f8a93e2607 SHA256 5c15e6c0ac7545c21f97e7c0fc0bbaedab04b2d155656568bef023738e46787b
 DIST gShield-2.8.tgz 47346 RMD160 77b1c7d23ea260e0d8785d8bc2987a185d4bc335 SHA1 a80db0f150c0691b566ed7e79f6ad0a5e0fda2d0 SHA256 19b04059ac4a6ad28f8653d804376779a83516ba4e0b5b041fe45d422ef68b85
 EBUILD gshield-2.8-r2.ebuild 1547 RMD160 fc341b8df25dce7e7114f48f77408ac3dade30bd SHA1 787053addf8015b3b7652d35ae36cc6cab8ce681 SHA256 233b0926657721bf625b6773f7ce276afc7e870bd8ae1086cc022adc87df17b1
-MISC ChangeLog 2022 RMD160 fdcece5e5926431acecc6fd440ce85efbe82ea60 SHA1 2ca2806f671c7b94c32d7e00c6c3cd4ec0df6217 SHA256 c28d374a04e66b9ddf3e48add710d8e5f7995baa87f90050d99cfe0573908138
+EBUILD gshield-2.8-r3.ebuild 1340 RMD160 4fe557d38c979f1d030dfa4232440bd6561440c2 SHA1 6eb4c4abf655aa8b6dcd2d4e24ed852d32fa8a06 SHA256 d841bf66ab718451feb730a838c506699a36317851501ed202a9d268c0ead9cd
+MISC ChangeLog 2325 RMD160 6d12be9e3d0fa2caa1c98d309cf83a27a069b0b8 SHA1 da53c8f491f93cf8eccfa99a82a6453affd30e5f SHA256 0137b38c48d3c11f2ca4bdc9e5957bc65eee0bc161c6c4a212e57e5c86514260
 MISC metadata.xml 159 RMD160 28e799fe0fd02aaab9d4bbe5595f133101606f5b SHA1 9f5df3eabd621951a959cc8e0e2e0d352cd1fe1e SHA256 b75c711bd971e46f0ec957e833c60879b0c5023e0bb94409a6255781b69f6dc6
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.17 (GNU/Linux)
 
-iEYEARECAAYFAk5QGk0ACgkQVWmRsqeSphPyYwCeNLIXIU6I6nR0dPFUU7d1Hn5M
-ZccAmwRAYuyrdR2XwOm2qJdXu7OCZerb
-=TTVe
+iEYEARECAAYFAk5QIT8ACgkQVWmRsqeSphNTYACfc9PcF2o/Mnf+PWQBRrlWm0tp
+sgUAn0Yo7KE7v5D5zjzMUz7nOW4U4KyN
+=8UT+
 -----END PGP SIGNATURE-----
diff --git a/net-firewall/gshield/gshield-2.8-r3.ebuild b/net-firewall/gshield/gshield-2.8-r3.ebuild
new file mode 100644
index 000000000000..1d6ae78c5501
--- /dev/null
+++ b/net-firewall/gshield/gshield-2.8-r3.ebuild
@@ -0,0 +1,50 @@
+# Copyright 1999-2011 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+# $Header: /var/cvsroot/gentoo-x86/net-firewall/gshield/gshield-2.8-r3.ebuild,v 1.1 2011/08/20 21:03:53 jer Exp $
+
+EAPI="4"
+
+DESCRIPTION="iptables firewall configuration system"
+HOMEPAGE="http://muse.linuxmafia.org/gshield.html"
+SRC_URI="ftp://muse.linuxmafia.org/pub/gShield/v2/gShield-${PV}.tgz"
+
+LICENSE="GPL-2"
+SLOT="0"
+KEYWORDS="~amd64 ~ppc ~x86"
+IUSE=""
+
+RDEPEND="net-firewall/iptables
+	net-dns/bind-tools
+	virtual/logger"
+
+src_unpack() {
+	# set S=${P}
+	unpack ${A}
+	mv * ${P} || die
+}
+
+src_install() {
+	# install config files
+	dodir /etc/gshield
+	cp -pPR * "${D}"/etc/gshield || die
+	ln -s gshield "${D}"/etc/firewall || die
+
+	# get rid of docs from config
+	rm -r "${D}"/etc/gshield/{Changelog,INSTALL,LICENSE,docs} || die
+
+	# move non-config stuff out of config, but make symlinks
+	dodir /usr/share/gshield/routables
+	for q in gShield-version gShield.rc tools sourced routables/routable.rules
+	do
+		mv "${D}"/etc/gshield/$q "${D}"/usr/share/gshield/ || die
+		ln -s /usr/share/gshield/$q "${D}"/etc/gshield/$q || die
+	done
+	chmod -R u+rwX "${D}"/etc/gshield || die
+
+	# install init script
+	newinitd "${FILESDIR}"/gshield.init gshield
+	chmod -R u+rwx "${D}"/etc/init.d/gshield || die
+
+	# install docs
+	dodoc Changelog docs/*
+}