Fix sprintf buffer overflow. Bug #358341

Package-Manager: portage-2.1.9.42/cvs/Linux x86_64

4 files changed, 25 insertions, 7 deletions

diff --git a/games-board/pouetchess/ChangeLog b/games-board/pouetchess/ChangeLog
index 11fb1fdf0a36..bff8aa634e3e 100644
--- a/games-board/pouetchess/ChangeLog
+++ b/games-board/pouetchess/ChangeLog
@@ -1,6 +1,10 @@
 # ChangeLog for games-board/pouetchess
-# Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/games-board/pouetchess/ChangeLog,v 1.14 2010/11/20 01:35:35 mr_bones_ Exp $
+# Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
+# $Header: /var/cvsroot/gentoo-x86/games-board/pouetchess/ChangeLog,v 1.15 2011/03/23 07:42:14 tupone Exp $
+
+  23 Mar 2011; Alfredo Tupone <tupone@gentoo.org>
+  pouetchess-0.2.0-r1.ebuild, files/pouetchess-0.2.0-segfaults.patch:
+  Fix sprintf buffer overflow. Bug #358341 by Joshua Landry
 
   20 Nov 2010; Michael Sterrett <mr_bones_@gentoo.org>
   pouetchess-0.2.0-r1.ebuild:
diff --git a/games-board/pouetchess/Manifest b/games-board/pouetchess/Manifest
index 1236113912f4..5d12edd61bec 100644
--- a/games-board/pouetchess/Manifest
+++ b/games-board/pouetchess/Manifest
@@ -1,8 +1,8 @@
 AUX pouetchess-0.2.0-gcc43.patch 309 RMD160 7db33dfa3a61c0fdacea9763b0d02061f7a197ef SHA1 2ca6cab683d7f36ac7848b0b9f0bf74123f484df SHA256 61fb67a699c11c36df6a178a997d3b678c62dfea16b2bd6c975166174aed3a12
 AUX pouetchess-0.2.0-nvidia_glext.patch 373 RMD160 34d53944251ea3b6363ba0a4a4a5cd7a831ffe93 SHA1 f3cb0e05c6fa782193408df5250ff4c225433e5b SHA256 d0466dee4b11efab347409e7e83fffac5ea9c6b1350b660c01b20a0107564a4b
 AUX pouetchess-0.2.0-sconstruct-sandbox.patch 754 RMD160 cd2b425d782fa1da12bd6a68c77f54d8b577c16b SHA1 ffbbf33d85f427cd04a7f57f4ec5e17d114ef3fb SHA256 0d0c7471bc5de6157f5d8c44dde061dbbf9215fc6b00bd4be590d41dabbdd70a
-AUX pouetchess-0.2.0-segfaults.patch 1195 RMD160 698eeb1561ec984fafa2ec398a467151b5a74642 SHA1 5d79a39c2b8a98c619f3f285d321cab5bc4b4796 SHA256 a0796702fdc434a337afa7579d8fee7076bfab06eb99171b6802ecf85a0ae4c2
+AUX pouetchess-0.2.0-segfaults.patch 1690 RMD160 119737eca2ec3ee2a0633480920d5143b5ae7df6 SHA1 035d6fe4a359c8e802a41ec3eec8d8abd6f3e0cb SHA256 97605336a668e8d7f343a5f35bc886c8d19f8aadf60d68be86ac25580776c8f7
 DIST pouetchess_src_0.2.0.tar.gz 1055338 RMD160 29611b78ef75b3707ad98752055da775335c0490 SHA1 023bea8043b5dcf8a134531b920497c7efb89adb SHA256 fe966ff1b0aa2dd6d0ca2b62692f5b788e3a286050a6a374e58ca0612f68b2ef
-EBUILD pouetchess-0.2.0-r1.ebuild 1596 RMD160 935885393caf074bc04b773d5bdd031df6fd1e25 SHA1 4767ef238e5e30a21a348ecb0b6e37401a0d5901 SHA256 d04a49a9deef833c52c9827eb6f79da399f986c2c23348063e07cfae11b10381
-MISC ChangeLog 2497 RMD160 67ace39485b1a784df6d316e1fa046eac2747936 SHA1 9b2e0bba0e75d5a05f3d4407e4ae0bdb0700e005 SHA256 c4d04f0b296ec9347f18f792b650782fdf562ed897f280c889791d3171a8ad2c
+EBUILD pouetchess-0.2.0-r1.ebuild 1613 RMD160 1295b0a1872e7e47339c48b914572e502e534920 SHA1 ababce1a6409afb1c5bc11a4c697fb9bdd8038a1 SHA256 b0a8a4e163bc520df208ec3eca14e6a521de02bd45a7d1fe4295f77e972b4637
+MISC ChangeLog 2675 RMD160 df4cbb194142641a2cc64976d5b34f349192bd47 SHA1 80ca7a07cbea7b5efe0488eab6920c6241b63ed1 SHA256 4e2dfe3d8ec450d3557339be99bf354a8c86195fe1208ebbdf8b13a6e53c4f54
 MISC metadata.xml 158 RMD160 cbd9984bb6b426c8c9cee5022fe0a26261612fea SHA1 be5251fa1dacef5c41b74761bb1c8c54fb633b9e SHA256 1423a4fdd4a79b1728a2056d9e300f7e1074253095d82726218d9e9b953888a3
diff --git a/games-board/pouetchess/files/pouetchess-0.2.0-segfaults.patch b/games-board/pouetchess/files/pouetchess-0.2.0-segfaults.patch
index 46b27b71d47e..58780e1b275e 100644
--- a/games-board/pouetchess/files/pouetchess-0.2.0-segfaults.patch
+++ b/games-board/pouetchess/files/pouetchess-0.2.0-segfaults.patch
@@ -42,3 +42,16 @@
  		{
  			// if a piece was already selected, this means the player want to move this piece
  			if (SquareXSelected>-1 && SquareZSelected>-1)
+--- src/graphic_chessboard.cpp.old	2011-03-23 08:08:40.000000000 +0100
++++ src/graphic_chessboard.cpp	2011-03-23 08:33:04.000000000 +0100
+@@ -122,8 +122,8 @@
+ 	
+ 	for(int i=0;i<6;i++)
+ 	{
+-		char texture_filename[50];
+-		sprintf(texture_filename,PC_DATA_TEXTURE_SKYBOX,i),
++		char texture_filename[256];
++		snprintf(texture_filename,sizeof(texture_filename),PC_DATA_TEXTURE_SKYBOX,i),
+ 		texture_skybox[i] = new CBasicTexture;
+ 		if (false==texture_skybox[i]->load(texture_filename,false))
+ 		{
diff --git a/games-board/pouetchess/pouetchess-0.2.0-r1.ebuild b/games-board/pouetchess/pouetchess-0.2.0-r1.ebuild
index 9ca71fd444b1..b312c331fe00 100644
--- a/games-board/pouetchess/pouetchess-0.2.0-r1.ebuild
+++ b/games-board/pouetchess/pouetchess-0.2.0-r1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2010 Gentoo Foundation
+# Copyright 1999-2011 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/games-board/pouetchess/pouetchess-0.2.0-r1.ebuild,v 1.10 2010/11/20 01:35:35 mr_bones_ Exp $
+# $Header: /var/cvsroot/gentoo-x86/games-board/pouetchess/pouetchess-0.2.0-r1.ebuild,v 1.11 2011/03/23 07:42:14 tupone Exp $
 
 EAPI=2
 inherit eutils scons-utils games
@@ -19,6 +19,7 @@ DEPEND="media-libs/libsdl
 	media-libs/sdl-image[jpeg,png]
 	virtual/glu
 	virtual/opengl"
+RDEPEND="${DEPEND}"
 
 S=${WORKDIR}/${PN}_src_${PV}
 PATCHES=( "${FILESDIR}/${P}-sconstruct-sandbox.patch"