*/*: [QA] Remove redundant `|| die` guards

* Since all ebuilds in the tree are EAPI>=4,
  `|| die` on builtin commands is redundant
  and dead code.

Closes: https://github.com/gentoo/gentoo/pull/13940
Reviewed-by: Ulrich Müller <ulm@gentoo.org>
Reviewed-by: Michał Górny <mgorny@gentoo.org>
Reviewed-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Signed-off-by: David Seifert <soap@gentoo.org>

6 files changed, 11 insertions, 12 deletions

diff --git a/sci-libs/lapack-reference/lapack-reference-3.2.1-r4.ebuild b/sci-libs/lapack-reference/lapack-reference-3.2.1-r4.ebuild
index 5a099088ec3b..0973af2b1f1c 100644
--- a/sci-libs/lapack-reference/lapack-reference-3.2.1-r4.ebuild
+++ b/sci-libs/lapack-reference/lapack-reference-3.2.1-r4.ebuild
@@ -79,8 +79,8 @@ src_install() {
 
 src_test() {
 	MAKEOPTS+=" -j1"
-	cd "${S}"/TESTING/MATGEN && emake || die
-	cd "${S}"/TESTING && emake || die
+	cd "${S}"/TESTING/MATGEN && emake
+	cd "${S}"/TESTING && emake
 }
 
 pkg_postinst() {
diff --git a/sci-libs/mkl/mkl-10.0.5.025-r1.ebuild b/sci-libs/mkl/mkl-10.0.5.025-r1.ebuild
index 0a4d33acc080..33fe7c30d1d4 100644
--- a/sci-libs/mkl/mkl-10.0.5.025-r1.ebuild
+++ b/sci-libs/mkl/mkl-10.0.5.025-r1.ebuild
@@ -307,7 +307,7 @@ src_install() {
 	# install license
 	if  [[ ! -f ${INTEL_LIC_DIR}/${MKL_LIC} ]]; then
 		insinto ${INTEL_LIC_DIR}
-		doins "${WORKDIR}"/${MKL_LIC} || die "install license failed"
+		doins "${WORKDIR}"/${MKL_LIC}
 	fi
 
 	# install main stuff: cp faster than doins
@@ -317,7 +317,7 @@ src_install() {
 	cp -pPR ${cpdirs} "${D}"${MKL_DIR} \
 		|| die "installing mkl failed"
 	insinto ${MKL_DIR}
-	doins -r ${doinsdirs} || die "doins ${doinsdirs} failed"
+	doins -r ${doinsdirs}
 	dosym mkl_cblas.h ${MKL_DIR}/include/cblas.h
 
 	# install blas/lapack profiles
diff --git a/sci-libs/mkl/mkl-10.0.5.025.ebuild b/sci-libs/mkl/mkl-10.0.5.025.ebuild
index 4de67341b9e1..dce78de61457 100644
--- a/sci-libs/mkl/mkl-10.0.5.025.ebuild
+++ b/sci-libs/mkl/mkl-10.0.5.025.ebuild
@@ -215,8 +215,7 @@ src_test() {
 		emake \
 			compiler=${MKL_FC} \
 			${myconf} \
-			so${MKL_ARCH} \
-			|| die "emake ${x} failed"
+			so${MKL_ARCH}
 		popd
 	done
 }
@@ -310,7 +309,7 @@ src_install() {
 	# install license
 	if  [[ ! -f ${INTEL_LIC_DIR}/${MKL_LIC} ]]; then
 		insinto ${INTEL_LIC_DIR}
-		doins "${WORKDIR}"/${MKL_LIC} || die "install license failed"
+		doins "${WORKDIR}"/${MKL_LIC}
 	fi
 
 	# install main stuff: cp faster than doins
@@ -320,7 +319,7 @@ src_install() {
 	cp -pPR ${cpdirs} "${D}"${MKL_DIR} \
 		|| die "installing mkl failed"
 	insinto ${MKL_DIR}
-	doins -r ${doinsdirs} || die "doins ${doinsdirs} failed"
+	doins -r ${doinsdirs}
 	dosym mkl_cblas.h ${MKL_DIR}/include/cblas.h
 
 	# install blas/lapack profiles
diff --git a/sci-libs/ogdi/ogdi-3.2.0.ebuild b/sci-libs/ogdi/ogdi-3.2.0.ebuild
index da6e21103bd3..7f42ae15c1e6 100644
--- a/sci-libs/ogdi/ogdi-3.2.0.ebuild
+++ b/sci-libs/ogdi/ogdi-3.2.0.ebuild
@@ -69,6 +69,6 @@ src_install() {
 	doins ogdi/include/ecs.h ogdi/include/ecs_util.h
 	dolib.so lib/${TARGET}/lib*
 	use static-libs && dolib.a lib/${TARGET}/static/*.a
-#	dosym libogdi31.so /usr/$(get_libdir)/libogdi.so || die "symlink failed"
+#	dosym libogdi31.so /usr/$(get_libdir)/libogdi.so
 	dodoc ChangeLog NEWS README
 }
diff --git a/sci-libs/ogdi/ogdi-3.2.0_beta2.ebuild b/sci-libs/ogdi/ogdi-3.2.0_beta2.ebuild
index 4e7a9c4adf8a..fcd803cbbad7 100644
--- a/sci-libs/ogdi/ogdi-3.2.0_beta2.ebuild
+++ b/sci-libs/ogdi/ogdi-3.2.0_beta2.ebuild
@@ -61,6 +61,6 @@ src_install() {
 	doins ogdi/include/ecs.h ogdi/include/ecs_util.h
 	dolib.so lib/${TARGET}/lib*
 	use static-libs && dolib.a lib/${TARGET}/static/*.a
-#	dosym libogdi31.so /usr/$(get_libdir)/libogdi.so || die "symlink failed"
+#	dosym libogdi31.so /usr/$(get_libdir)/libogdi.so
 	dodoc ChangeLog NEWS README
 }
diff --git a/sci-libs/plotmm/plotmm-0.1.2.ebuild b/sci-libs/plotmm/plotmm-0.1.2.ebuild
index e6a0447c3f7f..5cf316ca2678 100644
--- a/sci-libs/plotmm/plotmm-0.1.2.ebuild
+++ b/sci-libs/plotmm/plotmm-0.1.2.ebuild
@@ -40,7 +40,7 @@ src_install() {
 	default
 
 	if use doc; then
-		dohtml -r doc/html/* || die "dohtml failed"
+		dohtml -r doc/html/*
 	fi
 
 	if use examples; then
@@ -50,7 +50,7 @@ src_install() {
 
 		# install sources
 		insinto /usr/share/doc/${PF}/examples/
-		doins examples/{curves/curves,simple/simple}.cc || die "doins failed"
+		doins examples/{curves/curves,simple/simple}.cc
 
 		elog "You can use examples by calling ${PN}-curves or ${PN}-simple."
 		elog "Examples source code is in /usr/share/doc/${PF}/examples."