diff options
author | Fabian Groffen <grobian@gentoo.org> | 2022-02-12 18:08:42 +0100 |
---|---|---|
committer | Fabian Groffen <grobian@gentoo.org> | 2022-02-12 18:08:42 +0100 |
commit | ea84ef6ee024de6a24e0ee2f0cf557213a05c6b9 (patch) | |
tree | ada0fd89f39e62f85775bdf2a5d8064d1ffe6a48 /qmerge.c | |
parent | libq/tree: fix Coverity uninitialised memory use CID 248874 (diff) | |
download | portage-utils-ea84ef6ee024de6a24e0ee2f0cf557213a05c6b9.tar.gz portage-utils-ea84ef6ee024de6a24e0ee2f0cf557213a05c6b9.tar.bz2 portage-utils-ea84ef6ee024de6a24e0ee2f0cf557213a05c6b9.zip |
qmerge: fix Coverity dead code CID 248871
we previously checked rpkg == NULL, so indeed it can never be !NULL
(copy 'n' paste error)
Signed-off-by: Fabian Groffen <grobian@gentoo.org>
Diffstat (limited to 'qmerge.c')
-rw-r--r-- | qmerge.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -1523,12 +1523,12 @@ pkg_unmerge(tree_pkg_ctx *pkg_ctx, depend_atom *rpkg, set *keep, if (!pretend && rpkg == NULL) { buf = tree_pkg_meta_get(pkg_ctx, EAPI); if (buf == NULL) - buf = "0"; /* default */ + buf = (char *)"0"; /* default */ phases = tree_pkg_meta_get(pkg_ctx, DEFINED_PHASES); if (phases != NULL) { mkdirat(pkg_ctx->fd, "temp", 0755); pkg_run_func_at(pkg_ctx->fd, ".", phases, PKG_PRERM, - T, T, buf, rpkg == NULL ? "" : rpkg->PVR); + T, T, buf, ""); } } @@ -1664,7 +1664,7 @@ pkg_unmerge(tree_pkg_ctx *pkg_ctx, depend_atom *rpkg, set *keep, buf = tree_pkg_meta_get(pkg_ctx, EAPI); phases = tree_pkg_meta_get(pkg_ctx, DEFINED_PHASES); if (buf == NULL) - buf = "0"; /* default */ + buf = (char *)"0"; /* default */ if (phases != NULL) { /* execute the pkg_postrm step */ pkg_run_func_at(pkg_ctx->fd, ".", phases, PKG_POSTRM, |