aboutsummaryrefslogtreecommitdiff
blob: 3f587b05f9fdf71229fa25f52be8bf7cb719dcff (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.

=head1 NAME

Bugzilla::Field - a particular piece of information about bugs
                  and useful routines for form field manipulation

=head1 SYNOPSIS

  use Bugzilla;
  use Data::Dumper;

  # Display information about all fields.
  print Dumper(Bugzilla->fields());

  # Display information about non-obsolete custom fields.
  print Dumper(Bugzilla->active_custom_fields);

  use Bugzilla::Field;

  # Display information about non-obsolete custom fields.
  # Bugzilla->fields() is a wrapper around Bugzilla::Field->get_all(),
  # with arguments which filter the fields before returning them.
  print Dumper(Bugzilla->fields({ obsolete => 0, custom => 1 }));

  # Create or update a custom field or field definition.
  my $field = Bugzilla::Field->create(
    {name => 'cf_silly', description => 'Silly', custom => 1});

  # Instantiate a Field object for an existing field.
  my $field = new Bugzilla::Field({name => 'qacontact_accessible'});
  if ($field->obsolete) {
      say $field->description . " is obsolete";
  }

  # Validation Routines
  check_field($name, $value, \@legal_values, $no_warn);
  $fieldid = get_field_id($fieldname);

=head1 DESCRIPTION

Field.pm defines field objects, which represent the particular pieces
of information that Bugzilla stores about bugs.

This package also provides functions for dealing with CGI form fields.

C<Bugzilla::Field> is an implementation of L<Bugzilla::Object>, and
so provides all of the methods available in L<Bugzilla::Object>,
in addition to what is documented here.

=cut

package Bugzilla::Field;

use 5.10.1;
use strict;
use warnings;

use parent qw(Exporter Bugzilla::Object);
@Bugzilla::Field::EXPORT = qw(check_field get_field_id get_legal_field_values);

use Bugzilla::Constants;
use Bugzilla::Error;
use Bugzilla::Util;
use List::MoreUtils qw(any);

use Scalar::Util qw(blessed);

###############################
####    Initialization     ####
###############################

use constant IS_CONFIG => 1;

use constant DB_TABLE   => 'fielddefs';
use constant LIST_ORDER => 'sortkey, name';

use constant DB_COLUMNS => qw(
  id
  name
  description
  long_desc
  type
  custom
  mailhead
  sortkey
  obsolete
  enter_bug
  buglist
  visibility_field_id
  value_field_id
  reverse_desc
  is_mandatory
  is_numeric
);

use constant VALIDATORS => {
  custom              => \&_check_custom,
  description         => \&_check_description,
  long_desc           => \&_check_long_desc,
  enter_bug           => \&_check_enter_bug,
  buglist             => \&Bugzilla::Object::check_boolean,
  mailhead            => \&_check_mailhead,
  name                => \&_check_name,
  obsolete            => \&_check_obsolete,
  reverse_desc        => \&_check_reverse_desc,
  sortkey             => \&_check_sortkey,
  type                => \&_check_type,
  value_field_id      => \&_check_value_field_id,
  visibility_field_id => \&_check_visibility_field_id,
  visibility_values   => \&_check_visibility_values,
  is_mandatory        => \&Bugzilla::Object::check_boolean,
  is_numeric          => \&_check_is_numeric,
};

use constant VALIDATOR_DEPENDENCIES => {
  is_numeric        => ['type'],
  name              => ['custom'],
  type              => ['custom'],
  reverse_desc      => ['type'],
  value_field_id    => ['type'],
  visibility_values => ['visibility_field_id'],
};

use constant UPDATE_COLUMNS => qw(
  description
  long_desc
  mailhead
  sortkey
  obsolete
  enter_bug
  buglist
  visibility_field_id
  value_field_id
  reverse_desc
  is_mandatory
  is_numeric
  type
);

# How various field types translate into SQL data definitions.
use constant SQL_DEFINITIONS => {

  # Using commas because these are constants and they shouldn't
  # be auto-quoted by the "=>" operator.
  FIELD_TYPE_FREETEXT, {TYPE => 'varchar(255)', NOTNULL => 1, DEFAULT => "''"},
  FIELD_TYPE_SINGLE_SELECT,
  {TYPE => 'varchar(64)', NOTNULL => 1, DEFAULT => "'---'"}, FIELD_TYPE_TEXTAREA,
  {TYPE => 'MEDIUMTEXT',  NOTNULL => 1, DEFAULT => "''"},    FIELD_TYPE_DATETIME,
  {TYPE => 'DATETIME'}, FIELD_TYPE_DATE, {TYPE => 'DATE'}, FIELD_TYPE_BUG_ID,
  {TYPE => 'INT3'},     FIELD_TYPE_INTEGER,
  {TYPE => 'INT4', NOTNULL => 1, DEFAULT => 0},
};

# Field definitions for the fields that ship with Bugzilla.
# These are used by populate_field_definitions to populate
# the fielddefs table.
# 'days_elapsed' is set in populate_field_definitions() itself.
use constant DEFAULT_FIELDS => (
  {
    name           => 'bug_id',
    desc           => 'Bug #',
    in_new_bugmail => 1,
    buglist        => 1,
    is_numeric     => 1
  },
  {
    name           => 'short_desc',
    desc           => 'Summary',
    in_new_bugmail => 1,
    is_mandatory   => 1,
    buglist        => 1
  },
  {
    name           => 'classification',
    desc           => 'Classification',
    in_new_bugmail => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {
    name           => 'product',
    desc           => 'Product',
    in_new_bugmail => 1,
    is_mandatory   => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {
    name           => 'version',
    desc           => 'Version',
    in_new_bugmail => 1,
    is_mandatory   => 1,
    buglist        => 1
  },
  {
    name           => 'rep_platform',
    desc           => 'Platform',
    in_new_bugmail => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {name => 'bug_file_loc', desc => 'URL', in_new_bugmail => 1, buglist => 1},
  {
    name           => 'op_sys',
    desc           => 'OS/Version',
    in_new_bugmail => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {
    name           => 'bug_status',
    desc           => 'Status',
    in_new_bugmail => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {
    name           => 'status_whiteboard',
    desc           => 'Status Whiteboard',
    in_new_bugmail => 1,
    buglist        => 1
  },
  {
    name           => 'keywords',
    desc           => 'Keywords',
    in_new_bugmail => 1,
    type           => FIELD_TYPE_KEYWORDS,
    buglist        => 1
  },
  {
    name    => 'resolution',
    desc    => 'Resolution',
    type    => FIELD_TYPE_SINGLE_SELECT,
    buglist => 1
  },
  {
    name           => 'bug_severity',
    desc           => 'Severity',
    in_new_bugmail => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {
    name           => 'priority',
    desc           => 'Priority',
    in_new_bugmail => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {
    name           => 'component',
    desc           => 'Component',
    in_new_bugmail => 1,
    is_mandatory   => 1,
    type           => FIELD_TYPE_SINGLE_SELECT,
    buglist        => 1
  },
  {
    name           => 'assigned_to',
    desc           => 'AssignedTo',
    in_new_bugmail => 1,
    buglist        => 1
  },
  {name => 'reporter',   desc => 'ReportedBy', in_new_bugmail => 1, buglist => 1},
  {name => 'qa_contact', desc => 'QAContact',  in_new_bugmail => 1, buglist => 1},
  {
    name           => 'assigned_to_realname',
    desc           => 'AssignedToName',
    in_new_bugmail => 0,
    buglist        => 1
  },
  {
    name           => 'reporter_realname',
    desc           => 'ReportedByName',
    in_new_bugmail => 0,
    buglist        => 1
  },
  {
    name           => 'qa_contact_realname',
    desc           => 'QAContactName',
    in_new_bugmail => 0,
    buglist        => 1
  },
  {name => 'cc', desc => 'CC', in_new_bugmail => 1},
  {
    name           => 'dependson',
    desc           => 'Depends on',
    in_new_bugmail => 1,
    is_numeric     => 1,
    buglist        => 1
  },
  {
    name           => 'blocked',
    desc           => 'Blocks',
    in_new_bugmail => 1,
    is_numeric     => 1,
    buglist        => 1
  },

  {name => 'attachments.description', desc => 'Attachment description'},
  {name => 'attachments.filename',    desc => 'Attachment filename'},
  {name => 'attachments.mimetype',    desc => 'Attachment mime type'},
  {name => 'attachments.ispatch', desc => 'Attachment is patch', is_numeric => 1},
  {
    name       => 'attachments.isobsolete',
    desc       => 'Attachment is obsolete',
    is_numeric => 1
  },
  {
    name       => 'attachments.isprivate',
    desc       => 'Attachment is private',
    is_numeric => 1
  },
  {name => 'attachments.submitter', desc => 'Attachment creator'},

  {
    name           => 'target_milestone',
    desc           => 'Target Milestone',
    in_new_bugmail => 1,
    buglist        => 1
  },
  {name => 'creation_ts',         desc => 'Creation date',      buglist    => 1},
  {name => 'delta_ts',            desc => 'Last changed date',  buglist    => 1},
  {name => 'longdesc',            desc => 'Comment'},
  {name => 'longdescs.isprivate', desc => 'Comment is private', is_numeric => 1},
  {
    name       => 'longdescs.count',
    desc       => 'Number of Comments',
    buglist    => 1,
    is_numeric => 1
  },
  {name => 'alias',               desc => 'Alias',               buglist    => 1},
  {name => 'everconfirmed',       desc => 'Ever Confirmed',      is_numeric => 1},
  {name => 'reporter_accessible', desc => 'Reporter Accessible', is_numeric => 1},
  {name => 'cclist_accessible',   desc => 'CC Accessible',       is_numeric => 1},
  {name => 'bug_group', desc => 'Group', in_new_bugmail => 1},
  {
    name           => 'estimated_time',
    desc           => 'Estimated Hours',
    in_new_bugmail => 1,
    buglist        => 1,
    is_numeric     => 1
  },
  {
    name       => 'remaining_time',
    desc       => 'Remaining Hours',
    buglist    => 1,
    is_numeric => 1
  },
  {
    name           => 'deadline',
    desc           => 'Deadline',
    type           => FIELD_TYPE_DATETIME,
    in_new_bugmail => 1,
    buglist        => 1
  },
  {name => 'commenter',             desc => 'Commenter'},
  {name => 'flagtypes.name',        desc => 'Flags', buglist => 1},
  {name => 'requestees.login_name', desc => 'Flag Requestee'},
  {name => 'setters.login_name',    desc => 'Flag Setter'},
  {name => 'work_time', desc => 'Hours Worked', buglist => 1, is_numeric => 1},
  {
    name       => 'percentage_complete',
    desc       => 'Percentage Complete',
    buglist    => 1,
    is_numeric => 1
  },
  {name => 'content',             desc => 'Content'},
  {name => 'attach_data.thedata', desc => 'Attachment data'},
  {name => "owner_idle_time",     desc => "Time Since Assignee Touched"},
  {name => 'see_also', desc => "See Also", type => FIELD_TYPE_BUG_URLS},
  {
    name    => 'tag',
    desc    => 'Personal Tags',
    buglist => 1,
    type    => FIELD_TYPE_KEYWORDS
  },
  {
    name    => 'last_visit_ts',
    desc    => 'Last Visit',
    buglist => 1,
    type    => FIELD_TYPE_DATETIME
  },
  {name => 'comment_tag', desc => 'Comment Tag'},
);

################
# Constructors #
################

# Override match to add is_select.
sub match {
  my $self = shift;
  my ($params) = @_;
  if (delete $params->{is_select}) {
    $params->{type} = [FIELD_TYPE_SINGLE_SELECT, FIELD_TYPE_MULTI_SELECT];
  }
  return $self->SUPER::match(@_);
}

##############
# Validators #
##############

sub _check_custom { return $_[1] ? 1 : 0; }

sub _check_description {
  my ($invocant, $desc) = @_;
  $desc = clean_text($desc);
  $desc || ThrowUserError('field_missing_description');
  return $desc;
}

sub _check_long_desc {
  my ($invocant, $long_desc) = @_;
  $long_desc = clean_text($long_desc || '');
  if (length($long_desc) > MAX_FIELD_LONG_DESC_LENGTH) {
    ThrowUserError('field_long_desc_too_long');
  }
  return $long_desc;
}

sub _check_enter_bug { return $_[1] ? 1 : 0; }

sub _check_is_numeric {
  my ($invocant, $value, undef, $params) = @_;
  my $type = blessed($invocant) ? $invocant->type : $params->{type};
  return 1 if $type == FIELD_TYPE_BUG_ID;
  return $value ? 1 : 0;
}

sub _check_mailhead { return $_[1] ? 1 : 0; }

sub _check_name {
  my ($class, $name, undef, $params) = @_;
  $name = lc(clean_text($name));
  $name || ThrowUserError('field_missing_name');

  # Don't want to allow a name that might mess up SQL.
  my $name_regex = qr/^[\w\.]+$/;

  # Custom fields have more restrictive name requirements than
  # standard fields.
  $name_regex = qr/^[a-zA-Z0-9_]+$/ if $params->{custom};

  # Custom fields can't be named just "cf_", and there is no normal
  # field named just "cf_".
  ($name =~ $name_regex && $name ne "cf_")
    || ThrowUserError('field_invalid_name', {name => $name});

  # If it's custom, prepend cf_ to the custom field name to distinguish
  # it from standard fields.
  if ($name !~ /^cf_/ && $params->{custom}) {
    $name = 'cf_' . $name;
  }

  # Assure the name is unique. Names can't be changed, so we don't have
  # to worry about what to do on updates.
  my $field = new Bugzilla::Field({name => $name});
  ThrowUserError('field_already_exists', {'field' => $field}) if $field;

  return $name;
}

sub _check_obsolete { return $_[1] ? 1 : 0; }

sub _check_sortkey {
  my ($invocant, $sortkey) = @_;
  my $skey = $sortkey;
  if (!defined $skey || $skey eq '') {
    ($sortkey)
      = Bugzilla->dbh->selectrow_array('SELECT MAX(sortkey) + 100 FROM fielddefs')
      || 100;
  }
  detaint_natural($sortkey)
    || ThrowUserError('field_invalid_sortkey', {sortkey => $skey});
  return $sortkey;
}

sub _check_type {
  my ($invocant, $type, undef, $params) = @_;
  my $saved_type = $type;
  (detaint_natural($type) && $type < FIELD_TYPE_HIGHEST_PLUS_ONE)
    || ThrowCodeError('invalid_customfield_type', {type => $saved_type});

  my $custom = blessed($invocant) ? $invocant->custom : $params->{custom};
  if ($custom && !$type) {
    ThrowCodeError('field_type_not_specified');
  }

  return $type;
}

sub _check_value_field_id {
  my ($invocant, $field_id, undef, $params) = @_;
  my $is_select = $invocant->is_select($params);
  if ($field_id && !$is_select) {
    ThrowUserError('field_value_control_select_only');
  }
  return $invocant->_check_visibility_field_id($field_id);
}

sub _check_visibility_field_id {
  my ($invocant, $field_id) = @_;
  $field_id = trim($field_id);
  return undef if !$field_id;
  my $field = Bugzilla::Field->check({id => $field_id});
  if (blessed($invocant) && $field->id == $invocant->id) {
    ThrowUserError('field_cant_control_self', {field => $field});
  }
  if (!$field->is_select) {
    ThrowUserError('field_control_must_be_select', {field => $field});
  }
  return $field->id;
}

sub _check_visibility_values {
  my ($invocant, $values, undef, $params) = @_;
  my $field;
  if (blessed $invocant) {
    $field = $invocant->visibility_field;
  }
  elsif ($params->{visibility_field_id}) {
    $field = $invocant->new($params->{visibility_field_id});
  }

  # When no field is set, no values are set.
  return [] if !$field;

  if (!scalar @$values) {
    ThrowUserError('field_visibility_values_must_be_selected', {field => $field});
  }

  my @visibility_values;
  my $choice = Bugzilla::Field::Choice->type($field);
  foreach my $value (@$values) {
    if (!blessed $value) {
      $value = $choice->check({id => $value});
    }
    push(@visibility_values, $value);
  }

  return \@visibility_values;
}

sub _check_reverse_desc {
  my ($invocant, $reverse_desc, undef, $params) = @_;
  my $type = blessed($invocant) ? $invocant->type : $params->{type};
  if ($type != FIELD_TYPE_BUG_ID) {
    return undef;    # store NULL for non-reversible field types
  }

  $reverse_desc = clean_text($reverse_desc);
  return $reverse_desc;
}

sub _check_is_mandatory { return $_[1] ? 1 : 0; }

=pod

=head2 Instance Properties

=over

=item C<name>

the name of the field in the database; begins with "cf_" if field
is a custom field, but test the value of the boolean "custom" property
to determine if a given field is a custom field;

=item C<description>

a short string describing the field; displayed to Bugzilla users
in several places within Bugzilla's UI, f.e. as the form field label
on the "show bug" page;

=back

=cut

sub description { return $_[0]->{description} }

=over

=item C<long_desc>

A string providing detailed info about the field;

=back

=cut

sub long_desc { return $_[0]->{long_desc} }

=over

=item C<type>

an integer specifying the kind of field this is; values correspond to
the FIELD_TYPE_* constants in Constants.pm

=back

=cut

sub type { return $_[0]->{type} }

=over

=item C<custom>

a boolean specifying whether or not the field is a custom field;
if true, field name should start "cf_", but use this property to determine
which fields are custom fields;

=back

=cut

sub custom { return $_[0]->{custom} }

=over

=item C<in_new_bugmail>

a boolean specifying whether or not the field is displayed in bugmail
for newly-created bugs;

=back

=cut

sub in_new_bugmail { return $_[0]->{mailhead} }

=over

=item C<sortkey>

an integer specifying the sortkey of the field.

=back

=cut

sub sortkey { return $_[0]->{sortkey} }

=over

=item C<obsolete>

a boolean specifying whether or not the field is obsolete;

=back

=cut

sub obsolete { return $_[0]->{obsolete} }

=over

=item C<enter_bug>

A boolean specifying whether or not this field should appear on 
enter_bug.cgi

=back

=cut

sub enter_bug { return $_[0]->{enter_bug} }

=over

=item C<buglist>

A boolean specifying whether or not this field is selectable
as a display or order column in buglist.cgi

=back

=cut

sub buglist { return $_[0]->{buglist} }

=over

=item C<is_select>

True if this is a C<FIELD_TYPE_SINGLE_SELECT> or C<FIELD_TYPE_MULTI_SELECT>
field. It is only safe to call L</legal_values> if this is true.

=item C<legal_values>

Valid values for this field, as an array of L<Bugzilla::Field::Choice>
objects.

=back

=cut

sub is_select {
  my ($invocant, $params) = @_;

  # This allows this method to be called by create() validators.
  my $type = blessed($invocant) ? $invocant->type : $params->{type};
  return ($type == FIELD_TYPE_SINGLE_SELECT || $type == FIELD_TYPE_MULTI_SELECT)
    ? 1
    : 0;
}

=over

=item C<is_abnormal>

Most fields that have a C<SELECT> L</type> have a certain schema for
the table that stores their values, the table has the same name as the field,
and the field's legal values can be edited via F<editvalues.cgi>.

However, some fields do not follow that pattern. Those fields are
considered "abnormal".

This method returns C<1> if the field is "abnormal", C<0> otherwise.

=back

=cut

sub is_abnormal {
  my $self = shift;
  return ABNORMAL_SELECTS->{$self->name} ? 1 : 0;
}

sub legal_values {
  my $self = shift;

  if (!defined $self->{'legal_values'}) {
    require Bugzilla::Field::Choice;
    my @values = Bugzilla::Field::Choice->type($self)->get_all();
    $self->{'legal_values'} = \@values;
  }
  return $self->{'legal_values'};
}

=pod

=over

=item C<is_timetracking>

True if this is a time-tracking field that should only be shown to users
in the C<timetrackinggroup>.

=back

=cut

sub is_timetracking {
  my ($self) = @_;
  return grep($_ eq $self->name, TIMETRACKING_FIELDS) ? 1 : 0;
}

=pod

=over

=item C<visibility_field>

What field controls this field's visibility? Returns a C<Bugzilla::Field>
object representing the field that controls this field's visibility.

Returns undef if there is no field that controls this field's visibility.

=back

=cut

sub visibility_field {
  my $self = shift;
  if ($self->{visibility_field_id}) {
    $self->{visibility_field} ||= $self->new($self->{visibility_field_id});
  }
  return $self->{visibility_field};
}

=pod

=over

=item C<visibility_values>

If we have a L</visibility_field>, then what values does that field have to
be set to in order to show this field? Returns a L<Bugzilla::Field::Choice>
or undef if there is no C<visibility_field> set.

=back

=cut

sub visibility_values {
  my $self = shift;
  my $dbh  = Bugzilla->dbh;

  return [] if !$self->{visibility_field_id};

  if (!defined $self->{visibility_values}) {
    my $visibility_value_ids = $dbh->selectcol_arrayref(
      "SELECT value_id FROM field_visibility
                                      WHERE field_id = ?", undef, $self->id
    );

    $self->{visibility_values}
      = Bugzilla::Field::Choice->type($self->visibility_field)
      ->new_from_list($visibility_value_ids);
  }

  return $self->{visibility_values};
}

=pod

=over

=item C<controls_visibility_of>

An arrayref of C<Bugzilla::Field> objects, representing fields that this
field controls the visibility of.

=back

=cut

sub controls_visibility_of {
  my $self = shift;
  $self->{controls_visibility_of}
    ||= Bugzilla::Field->match({visibility_field_id => $self->id});
  return $self->{controls_visibility_of};
}

=pod

=over

=item C<value_field>

The Bugzilla::Field that controls the list of values for this field.

Returns undef if there is no field that controls this field's visibility.

=back

=cut

sub value_field {
  my $self = shift;
  if ($self->{value_field_id}) {
    $self->{value_field} ||= $self->new($self->{value_field_id});
  }
  return $self->{value_field};
}

=pod

=over

=item C<controls_values_of>

An arrayref of C<Bugzilla::Field> objects, representing fields that this
field controls the values of.

=back

=cut

sub controls_values_of {
  my $self = shift;
  $self->{controls_values_of}
    ||= Bugzilla::Field->match({value_field_id => $self->id});
  return $self->{controls_values_of};
}

=over

=item C<is_visible_on_bug>

See L<Bugzilla::Field::ChoiceInterface>.

=back

=cut

sub is_visible_on_bug {
  my ($self, $bug) = @_;

  # Always return visible, if this field is not
  # visibility controlled.
  return 1 if !$self->{visibility_field_id};

  my $visibility_values = $self->visibility_values;

  return (any { $_->is_set_on_bug($bug) } @$visibility_values) ? 1 : 0;
}

=over

=item C<is_relationship>

Applies only to fields of type FIELD_TYPE_BUG_ID.
Checks to see if a reverse relationship description has been set.
This is the canonical condition to enable reverse link display,
dependency tree display, and similar functionality.

=back

=cut

sub is_relationship {
  my $self = shift;
  my $desc = $self->reverse_desc;
  if (defined $desc && $desc ne "") {
    return 1;
  }
  return 0;
}

=over

=item C<reverse_desc>

Applies only to fields of type FIELD_TYPE_BUG_ID.
Describes the reverse relationship of this field.
For example, if a BUG_ID field is called "Is a duplicate of",
the reverse description would be "Duplicates of this bug".

=back

=cut

sub reverse_desc { return $_[0]->{reverse_desc} }

=over

=item C<is_mandatory>

a boolean specifying whether or not the field is mandatory;

=back

=cut

sub is_mandatory { return $_[0]->{is_mandatory} }

=over

=item C<is_numeric>

A boolean specifying whether or not this field logically contains
numeric (integer, decimal, or boolean) values. By "logically contains" we
mean that the user inputs numbers into the value of the field in the UI.
This is mostly used by L<Bugzilla::Search>.

=back

=cut

sub is_numeric { return $_[0]->{is_numeric} }


=pod

=head2 Instance Mutators

These set the particular field that they are named after.

They take a single value--the new value for that field.

They will throw an error if you try to set the values to something invalid.

=over

=item C<set_description>

=item C<set_long_desc>

=item C<set_enter_bug>

=item C<set_obsolete>

=item C<set_sortkey>

=item C<set_in_new_bugmail>

=item C<set_buglist>

=item C<set_reverse_desc>

=item C<set_visibility_field>

=item C<set_visibility_values>

=item C<set_value_field>

=item C<set_is_mandatory>


=back

=cut

sub set_description    { $_[0]->set('description',  $_[1]); }
sub set_long_desc      { $_[0]->set('long_desc',    $_[1]); }
sub set_enter_bug      { $_[0]->set('enter_bug',    $_[1]); }
sub set_is_numeric     { $_[0]->set('is_numeric',   $_[1]); }
sub set_obsolete       { $_[0]->set('obsolete',     $_[1]); }
sub set_sortkey        { $_[0]->set('sortkey',      $_[1]); }
sub set_in_new_bugmail { $_[0]->set('mailhead',     $_[1]); }
sub set_buglist        { $_[0]->set('buglist',      $_[1]); }
sub set_reverse_desc   { $_[0]->set('reverse_desc', $_[1]); }

sub set_visibility_field {
  my ($self, $value) = @_;
  $self->set('visibility_field_id', $value);
  delete $self->{visibility_field};
  delete $self->{visibility_values};
}

sub set_visibility_values {
  my ($self, $value_ids) = @_;
  $self->set('visibility_values', $value_ids);
}

sub set_value_field {
  my ($self, $value) = @_;
  $self->set('value_field_id', $value);
  delete $self->{value_field};
}
sub set_is_mandatory { $_[0]->set('is_mandatory', $_[1]); }

# This is only used internally by upgrade code in Bugzilla::Field.
sub _set_type { $_[0]->set('type', $_[1]); }

=pod

=head2 Instance Method

=over

=item C<remove_from_db>

Attempts to remove the passed in field from the database.
Deleting a field is only successful if the field is obsolete and
there are no values specified (or EVER specified) for the field.

=back

=cut

sub remove_from_db {
  my $self = shift;
  my $dbh  = Bugzilla->dbh;

  my $name = $self->name;

  if (!$self->custom) {
    ThrowCodeError('field_not_custom', {'name' => $name});
  }

  if (!$self->obsolete) {
    ThrowUserError('customfield_not_obsolete', {'name' => $self->name});
  }

  $dbh->bz_start_transaction();

  # Check to see if bug activity table has records (should be fast with index)
  my $has_activity = $dbh->selectrow_array(
    "SELECT COUNT(*) FROM bugs_activity
                                      WHERE fieldid = ?", undef, $self->id
  );
  if ($has_activity) {
    ThrowUserError('customfield_has_activity', {'name' => $name});
  }

  # Check to see if bugs table has records (slow)
  my $bugs_query = "";

  if ($self->type == FIELD_TYPE_MULTI_SELECT) {
    $bugs_query = "SELECT COUNT(*) FROM bug_$name";
  }
  else {
    $bugs_query = "SELECT COUNT(*) FROM bugs WHERE $name IS NOT NULL";
    if ( $self->type != FIELD_TYPE_BUG_ID
      && $self->type != FIELD_TYPE_DATE
      && $self->type != FIELD_TYPE_DATETIME)
    {
      $bugs_query .= " AND $name != ''";
    }

    # Ignore the default single select value
    if ($self->type == FIELD_TYPE_SINGLE_SELECT) {
      $bugs_query .= " AND $name != '---'";
    }
  }

  my $has_bugs = $dbh->selectrow_array($bugs_query);
  if ($has_bugs) {
    ThrowUserError('customfield_has_contents', {'name' => $name});
  }

  # Once we reach here, we should be OK to delete.
  $self->SUPER::remove_from_db();

  my $type = $self->type;

  # the values for multi-select are stored in a seperate table
  if ($type != FIELD_TYPE_MULTI_SELECT) {
    $dbh->bz_drop_column('bugs', $name);
  }

  if ($self->is_select) {

    # Delete the table that holds the legal values for this field.
    $dbh->bz_drop_field_tables($self);
  }

  $dbh->bz_commit_transaction();
}

=pod

=head2 Class Methods

=over

=item C<create>

Just like L<Bugzilla::Object/create>. Takes the following parameters:

=over

=item C<name> B<Required> - The name of the field.

=item C<description> B<Required> - The field label to display in the UI.

=item C<long_desc> - A longer description of the field.

=item C<mailhead> - boolean - Whether this field appears at the
top of the bugmail for a newly-filed bug. Defaults to 0.

=item C<custom> - boolean - True if this is a Custom Field. The field
will be added to the C<bugs> table if it does not exist. Defaults to 0.

=item C<sortkey> - integer - The sortkey of the field. Defaults to 0.

=item C<enter_bug> - boolean - Whether this field is
editable on the bug creation form. Defaults to 0.

=item C<buglist> - boolean - Whether this field is
selectable as a display or order column in bug lists. Defaults to 0.

C<obsolete> - boolean - Whether this field is obsolete. Defaults to 0.

C<is_mandatory> - boolean - Whether this field is mandatory. Defaults to 0.

=back

=back

=cut

sub create {
  my $class    = shift;
  my ($params) = @_;
  my $dbh      = Bugzilla->dbh;

  # This makes sure the "sortkey" validator runs, even if
  # the parameter isn't sent to create().
  $params->{sortkey} = undef if !exists $params->{sortkey};
  $params->{type} ||= 0;

  # We mark the custom field as obsolete till it has been fully created,
  # to avoid race conditions when viewing bugs at the same time.
  my $is_obsolete = $params->{obsolete};
  $params->{obsolete} = 1 if $params->{custom};

  $dbh->bz_start_transaction();
  $class->check_required_create_fields(@_);
  my $field_values      = $class->run_create_validators($params);
  my $visibility_values = delete $field_values->{visibility_values};
  my $field             = $class->insert_create_data($field_values);

  $field->set_visibility_values($visibility_values);
  $field->_update_visibility_values();

  $dbh->bz_commit_transaction();
  Bugzilla->memcached->clear_config();

  if ($field->custom) {
    my $name = $field->name;
    my $type = $field->type;
    if (SQL_DEFINITIONS->{$type}) {

      # Create the database column that stores the data for this field.
      $dbh->bz_add_column('bugs', $name, SQL_DEFINITIONS->{$type});
    }

    if ($field->is_select) {

      # Create the table that holds the legal values for this field.
      $dbh->bz_add_field_tables($field);
    }

    if ($type == FIELD_TYPE_SINGLE_SELECT) {

      # Insert a default value of "---" into the legal values table.
      $dbh->do("INSERT INTO $name (value) VALUES ('---')");
    }

    # Restore the original obsolete state of the custom field.
    $dbh->do('UPDATE fielddefs SET obsolete = 0 WHERE id = ?', undef, $field->id)
      unless $is_obsolete;

    Bugzilla->memcached->clear({table => 'fielddefs', id => $field->id});
    Bugzilla->memcached->clear_config();
  }

  return $field;
}

sub update {
  my $self    = shift;
  my $changes = $self->SUPER::update(@_);
  my $dbh     = Bugzilla->dbh;
  if ($changes->{value_field_id} && $self->is_select) {
    $dbh->do("UPDATE " . $self->name . " SET visibility_value_id = NULL");
  }
  $self->_update_visibility_values();
  Bugzilla->memcached->clear_config();
  return $changes;
}

sub _update_visibility_values {
  my $self = shift;
  my $dbh  = Bugzilla->dbh;

  my @visibility_value_ids = map($_->id, @{$self->visibility_values});
  $self->_delete_visibility_values();
  for my $value_id (@visibility_value_ids) {
    $dbh->do(
      "INSERT INTO field_visibility (field_id, value_id)
                  VALUES (?, ?)", undef, $self->id, $value_id
    );
  }
}

sub _delete_visibility_values {
  my ($self) = @_;
  my $dbh = Bugzilla->dbh;
  $dbh->do("DELETE FROM field_visibility WHERE field_id = ?", undef, $self->id);
  delete $self->{visibility_values};
}

=pod

=over

=item C<get_legal_field_values($field)>

Description: returns all the legal values for a field that has a
             list of legal values, like rep_platform or resolution.
             The table where these values are stored must at least have
             the following columns: value, isactive, sortkey.

Params:    C<$field> - Name of the table where valid values are.

Returns:   a reference to a list of valid values.

=back

=cut

sub get_legal_field_values {
  my ($field)    = @_;
  my $dbh        = Bugzilla->dbh;
  my $result_ref = $dbh->selectcol_arrayref(
    "SELECT value FROM $field
           WHERE isactive = ?
        ORDER BY sortkey, value", undef, (1)
  );
  return $result_ref;
}

=over

=item C<populate_field_definitions()>

Description: Populates the fielddefs table during an installation
             or upgrade.

Params:      none

Returns:     nothing

=back

=cut

sub populate_field_definitions {
  my $dbh = Bugzilla->dbh;

  # ADD and UPDATE field definitions
  foreach my $def (DEFAULT_FIELDS) {
    my $field = new Bugzilla::Field({name => $def->{name}});
    if ($field) {
      $field->set_description($def->{desc});
      $field->set_in_new_bugmail($def->{in_new_bugmail});
      $field->set_buglist($def->{buglist});
      $field->_set_type($def->{type}) if $def->{type};
      $field->set_is_mandatory($def->{is_mandatory});
      $field->set_is_numeric($def->{is_numeric});
      $field->update();
    }
    else {
      if (exists $def->{in_new_bugmail}) {
        $def->{mailhead} = $def->{in_new_bugmail};
        delete $def->{in_new_bugmail};
      }
      $def->{description} = delete $def->{desc};
      Bugzilla::Field->create($def);
    }
  }

  # DELETE fields which were added only accidentally, or which
  # were never tracked in bugs_activity. Note that you can never
  # delete fields which are used by bugs_activity.

  # Oops. Bug 163299
  $dbh->do("DELETE FROM fielddefs WHERE name='cc_accessible'");

  # Oops. Bug 215319
  $dbh->do("DELETE FROM fielddefs WHERE name='requesters.login_name'");

  # This field was never tracked in bugs_activity, so it's safe to delete.
  $dbh->do("DELETE FROM fielddefs WHERE name='attachments.thedata'");

  # MODIFY old field definitions

  # 2005-11-13 LpSolit@gmail.com - Bug 302599
  # One of the field names was a fragment of SQL code, which is DB dependent.
  # We have to rename it to a real name, which is DB independent.
  my $new_field_name    = 'days_elapsed';
  my $field_description = 'Days since bug changed';

  my ($old_field_id, $old_field_name) = $dbh->selectrow_array(
    'SELECT id, name FROM fielddefs
                                WHERE description = ?', undef, $field_description
  );

  if ($old_field_id && ($old_field_name ne $new_field_name)) {
    say "SQL fragment found in the 'fielddefs' table...";
    say "Old field name: $old_field_name";

    # We have to fix saved searches first. Queries have been escaped
    # before being saved. We have to do the same here to find them.
    $old_field_name = url_quote($old_field_name);
    my $broken_named_queries = $dbh->selectall_arrayref(
      'SELECT userid, name, query
                                        FROM namedqueries WHERE '
        . $dbh->sql_istrcmp('query', '?', 'LIKE'), undef, "%=$old_field_name%"
    );

    my $sth_UpdateQueries = $dbh->prepare(
      'UPDATE namedqueries SET query = ?
                                                WHERE userid = ? AND name = ?'
    );

    print "Fixing saved searches...\n" if scalar(@$broken_named_queries);
    foreach my $named_query (@$broken_named_queries) {
      my ($userid, $name, $query) = @$named_query;
      $query =~ s/=\Q$old_field_name\E(&|$)/=$new_field_name$1/gi;
      $sth_UpdateQueries->execute($query, $userid, $name);
    }

    # We now do the same with saved chart series.
    my $broken_series = $dbh->selectall_arrayref(
      'SELECT series_id, query
                                        FROM series WHERE '
        . $dbh->sql_istrcmp('query', '?', 'LIKE'), undef, "%=$old_field_name%"
    );

    my $sth_UpdateSeries = $dbh->prepare(
      'UPDATE series SET query = ?
                                               WHERE series_id = ?'
    );

    print "Fixing saved chart series...\n" if scalar(@$broken_series);
    foreach my $series (@$broken_series) {
      my ($series_id, $query) = @$series;
      $query =~ s/=\Q$old_field_name\E(&|$)/=$new_field_name$1/gi;
      $sth_UpdateSeries->execute($query, $series_id);
    }

    # Now that saved searches have been fixed, we can fix the field name.
    say "Fixing the 'fielddefs' table...";
    say "New field name: $new_field_name";
    $dbh->do('UPDATE fielddefs SET name = ? WHERE id = ?',
      undef, ($new_field_name, $old_field_id));
  }

  # This field has to be created separately, or the above upgrade code
  # might not run properly.
  Bugzilla::Field->create(
    {name => $new_field_name, description => $field_description})
    unless new Bugzilla::Field({name => $new_field_name});

}


=head2 Data Validation

=over

=item C<check_field($name, $value, \@legal_values, $no_warn)>

Description: Makes sure the field $name is defined and its $value
             is non empty. If @legal_values is defined, this routine
             checks whether its value is one of the legal values
             associated with this field, else it checks against
             the default valid values for this field obtained by
             C<get_legal_field_values($name)>. If the test is successful,
             the function returns 1. If the test fails, an error
             is thrown (by default), unless $no_warn is true, in which
             case the function returns 0.

Params:      $name         - the field name
             $value        - the field value
             @legal_values - (optional) list of legal values
             $no_warn      - (optional) do not throw an error if true

Returns:     1 on success; 0 on failure if $no_warn is true (else an
             error is thrown).

=back

=cut

sub check_field {
  my ($name, $value, $legalsRef, $no_warn) = @_;
  my $dbh = Bugzilla->dbh;

  # If $legalsRef is undefined, we use the default valid values.
  # Valid values for this check are all possible values.
  # Using get_legal_values would only return active values, but since
  # some bugs may have inactive values set, we want to check them too.
  unless (defined $legalsRef) {
    $legalsRef = Bugzilla::Field->new({name => $name})->legal_values;
    my @values = map($_->name, @$legalsRef);
    $legalsRef = \@values;

  }

  if ( !defined($value)
    or trim($value) eq ""
    or !grep { $_ eq $value } @$legalsRef)
  {
    return 0 if $no_warn;    # We don't want an error to be thrown; return.
    trick_taint($name);

    my $field = new Bugzilla::Field({name => $name});
    my $field_desc = $field ? $field->description : $name;
    ThrowCodeError('illegal_field', {field => $field_desc});
  }
  return 1;
}

=pod

=over

=item C<get_field_id($fieldname)>

Description: Returns the ID of the specified field name and throws
             an error if this field does not exist.

Params:      $fieldname - a field name

Returns:     the corresponding field ID or an error if the field name
             does not exist.

=back

=cut

sub get_field_id {
  my $field = Bugzilla->fields({by_name => 1})->{$_[0]}
    or ThrowCodeError('invalid_field_name', {field => $_[0]});

  return $field->id;
}

1;

__END__

=head1 B<Methods in need of POD>

=over

=item match

=item set_is_numeric

=item update

=back