Patch to fix segmentation fault with non-interactive pam by Andrea Luzzardi in bug 180542.

(Portage version: 2.1.2.9)

4 files changed, 189 insertions, 1 deletions

diff --git a/x11-misc/xscreensaver/ChangeLog b/x11-misc/xscreensaver/ChangeLog
index 489ceea8c0f2..8840c5fb9ee1 100644
--- a/x11-misc/xscreensaver/ChangeLog
+++ b/x11-misc/xscreensaver/ChangeLog
@@ -1,6 +1,13 @@
 # ChangeLog for x11-misc/xscreensaver
 # Copyright 2002-2007 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/x11-misc/xscreensaver/ChangeLog,v 1.182 2007/05/27 05:00:19 kumba Exp $
+# $Header: /var/cvsroot/gentoo-x86/x11-misc/xscreensaver/ChangeLog,v 1.183 2007/06/06 19:11:00 drac Exp $
+
+*xscreensaver-5.02-r2 (06 Jun 2007)
+
+  06 Jun 2007; Samuli Suominen <drac@gentoo.org>
+  +files/xscreensaver-5.02-pam.patch, +xscreensaver-5.02-r2.ebuild:
+  Patch to fix segmentation fault with non-interactive pam by Andrea Luzzardi
+  in bug 180542.
 
   27 May 2007; Joshua Kinard <kumba@gentoo.org> xscreensaver-5.02-r1.ebuild:
   Stable on mips.
diff --git a/x11-misc/xscreensaver/files/digest-xscreensaver-5.02-r2 b/x11-misc/xscreensaver/files/digest-xscreensaver-5.02-r2
new file mode 100644
index 000000000000..fdfae96d63a8
--- /dev/null
+++ b/x11-misc/xscreensaver/files/digest-xscreensaver-5.02-r2
@@ -0,0 +1,3 @@
+MD5 83937791b30f55f52011d4fee0f5dff3 xscreensaver-5.02.tar.gz 5371759
+RMD160 b70fcfb0d4958134823a9fd7a288297c53fef270 xscreensaver-5.02.tar.gz 5371759
+SHA256 0cb7e7653196701c31c2ee66f276f467bd8a9889a71c378aedc3b1fa2b8e879d xscreensaver-5.02.tar.gz 5371759
diff --git a/x11-misc/xscreensaver/files/xscreensaver-5.02-pam.patch b/x11-misc/xscreensaver/files/xscreensaver-5.02-pam.patch
new file mode 100644
index 000000000000..c4653727b2db
--- /dev/null
+++ b/x11-misc/xscreensaver/files/xscreensaver-5.02-pam.patch
@@ -0,0 +1,13 @@
+diff -ur xscreensaver-5.02.orig/driver/lock.c xscreensaver-5.02/driver/lock.c
+--- xscreensaver-5.02.orig/driver/lock.c	2007-04-20 13:15:56.000000000 +0300
++++ xscreensaver-5.02/driver/lock.c	2007-06-06 21:48:51.000000000 +0300
+@@ -2066,7 +2066,8 @@
+       }
+     }
+ 
+-  destroy_passwd_window (si);
++  if (si->pw_data)
++    destroy_passwd_window (si);
+ }
+ 
+ 
diff --git a/x11-misc/xscreensaver/xscreensaver-5.02-r2.ebuild b/x11-misc/xscreensaver/xscreensaver-5.02-r2.ebuild
new file mode 100644
index 000000000000..32531c72aba0
--- /dev/null
+++ b/x11-misc/xscreensaver/xscreensaver-5.02-r2.ebuild
@@ -0,0 +1,165 @@
+# Copyright 1999-2007 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+# $Header: /var/cvsroot/gentoo-x86/x11-misc/xscreensaver/xscreensaver-5.02-r2.ebuild,v 1.1 2007/06/06 19:11:00 drac Exp $
+
+inherit eutils flag-o-matic pam fixheadtails autotools
+
+DESCRIPTION="A modular screen saver and locker for the X Window System"
+SRC_URI="http://www.jwz.org/xscreensaver/${P}.tar.gz"
+HOMEPAGE="http://www.jwz.org/xscreensaver"
+
+LICENSE="BSD"
+SLOT="0"
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~x86-fbsd"
+IUSE="gnome jpeg insecure-savers new-login offensive opengl pam xinerama"
+
+RDEPEND="x11-libs/libXxf86misc
+	x11-apps/xwininfo
+	x11-apps/appres
+	media-libs/netpbm
+	>=sys-libs/zlib-1.1.4
+	>=dev-libs/libxml2-2.5
+	>=x11-libs/gtk+-2
+	>=gnome-base/libglade-1.99
+	>=dev-libs/glib-2
+	pam? ( virtual/pam )
+	jpeg? ( media-libs/jpeg )
+	opengl? ( virtual/opengl
+		>=media-libs/gle-3.0.1 )
+	xinerama? ( x11-libs/libXinerama )
+	new-login? ( gnome-base/gdm )"
+DEPEND="${RDEPEND}
+	x11-proto/xf86vidmodeproto
+	x11-proto/xextproto
+	x11-proto/scrnsaverproto
+	x11-proto/recordproto
+	x11-proto/xf86miscproto
+	sys-devel/bc
+	dev-util/pkgconfig
+	sys-devel/gettext
+	dev-util/intltool
+	xinerama? ( x11-proto/xineramaproto )"
+
+src_unpack() {
+	unpack ${A}
+	cd "${S}"
+
+	# Bug fixes:
+	epatch "${FILESDIR}/${PN}-5.01-gentoo.patch"
+
+	# disable not-safe-for-work xscreensavers
+	use offensive || epatch "${FILESDIR}/${P}-nsfw.patch"
+
+	# Fix bug #154444 - hypertorus hack:
+	epatch "${FILESDIR}/${PN}-5.01-hypertorus.xml.patch"
+
+	epatch "${FILESDIR}"/${P}-gdmflexiserver.patch
+
+	# bug 180542. fix for segmentation fault with non-interactive pam.
+	epatch "${FILESDIR}"/${P}-pam.patch
+
+	eautoreconf
+
+	# change old head/tail to POSIX ones
+	ht_fix_all
+
+}
+
+src_compile() {
+	# simple workaround for the flurry screensaver
+	filter-flags -mabi=altivec
+	filter-flags -maltivec
+	append-flags -U__VEC__
+
+	unset BC_ENV_ARGS
+	econf \
+		--with-hackdir=/usr/lib/misc/xscreensaver \
+		--with-configdir=/usr/share/xscreensaver/config \
+		--x-libraries=/usr/$(get_libdir) \
+		--x-includes=/usr/include \
+		--with-dpms-ext \
+		--with-xf86vmode-ext \
+		--with-xf86gamma-ext \
+		--with-proc-interrupts \
+		--with-xpm \
+		--with-xshm-ext \
+		--with-xdbe-ext \
+		--enable-locking \
+		--with-gtk \
+		--without-kerberos \
+		$(use_with insecure-savers setuid-hacks) \
+		$(use_with new-login login-manager) \
+		$(use_with xinerama xinerama-ext) \
+		$(use_with pam) \
+		$(use_with opengl gl) $(use_with opengl gle) \
+		$(use_with jpeg)
+
+	# bug 155049
+	emake -j1 || die "emake failed."
+}
+
+src_install() {
+	[[ -n "${KDEDIR}" ]] && dodir "${KDEDIR}/bin"
+
+	emake install_prefix="${D}" install || die "emake install failed."
+
+	dodoc README*
+
+	# install correctly in gnome, including info about configuration preferences
+	if use gnome; then
+		dodir /usr/share/gnome/capplets
+		insinto /usr/share/gnome/capplets
+		doins driver/screensaver-properties.desktop
+
+		newicon "${S}/utils/images/logo-50.xpm" xscreensaver.xpm
+
+		dodir /usr/share/control-center-2.0/capplets
+		insinto /usr/share/control-center-2.0/capplets
+		newins "${FILESDIR}/desktop_entries/screensaver-properties.desktop"
+	fi
+
+	# Remove "extra" capplet
+	rm -f "${D}/usr/share/applications/gnome-screensaver-properties.desktop"
+
+	# Allways install Settings .desktop for enviroments following
+	# freedesktop.org standard, e.g. xfce-base/xfdesktop and rox-base/xdg-menu
+	domenu "${FILESDIR}/desktop_entries/screensaver-properties.desktop"
+
+	use pam && fperms 755 /usr/bin/xscreensaver
+	pamd_mimic_system xscreensaver auth
+
+	# Fix bug #135549:
+	rm -f "${D}/usr/share/xscreensaver/config/electricsheep.xml"
+	rm -f "${D}/usr/share/xscreensaver/config/fireflies.xml"
+	dodir /usr/share/man/man6x
+	mv "${D}/usr/share/man/man6/worm.6" \
+		"${D}/usr/share/man/man6x/worm.6x"
+
+	# Fix bug #152250:
+	dodir "/usr/share/X11/app-defaults"
+	mv "${D}/usr/lib/X11/app-defaults/XScreenSaver" \
+		"${D}/usr/share/X11/app-defaults/XScreenSaver"
+}
+
+pkg_postinst() {
+	if ! use new-login; then
+		elog
+		elog "You have chosen to not use the new-login USE flag."
+		elog "This is a new USE flag which enables individuals to"
+		elog "create new logins when the screensaver is active,"
+		elog "allowing others to use their account, even though the"
+		elog "screen is locked to another account. If you want this"
+		elog "feature, please recompile with USE=\"new-login\"."
+		elog
+	fi
+
+	if use insecure-savers;then
+		ewarn
+		ewarn "You have chosen USE=insecure-savers. While upstream"
+		ewarn "has made every effort to make sure these savers do not"
+		ewarn "abuse their setuid root status, the possibilty exists that"
+		ewarn "someone will exploit xscreensaver and will be able to gain"
+		ewarn "root privileges. You have been warned."
+		ewarn
+	fi
+}