Move inherit to top of ebuilds for bug 117764, add quotes to S, D, etc.

(Portage version: 2.0.54)

4 files changed, 22 insertions, 16 deletions

diff --git a/rox-base/rox-session/ChangeLog b/rox-base/rox-session/ChangeLog
index 485aee86b95d..dae86cc91492 100644
--- a/rox-base/rox-session/ChangeLog
+++ b/rox-base/rox-session/ChangeLog
@@ -1,6 +1,12 @@
 # ChangeLog for rox-base/rox-session
-# Copyright 2000-2005 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/ChangeLog,v 1.4 2005/10/12 20:32:47 svyatogor Exp $
+# Copyright 2000-2006 Gentoo Foundation; Distributed under the GPL v2
+# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/ChangeLog,v 1.5 2006/01/18 20:36:58 vanquirius Exp $
+
+  18 Jan 2006; Marcelo Goes <vanquirius@gentoo.org>
+  rox-session-0.1.20.ebuild, rox-session-0.1.21.ebuild,
+  rox-session-0.26.ebuild:
+  Move inherit to top of ebuilds for bug 117764, add quotes to S, D, etc.
+  Thanks to Alexandru Toma <flash3001 at yahoo dot com>.
 
 *rox-session-0.26 (12 Oct 2005)
 
diff --git a/rox-base/rox-session/rox-session-0.1.20.ebuild b/rox-base/rox-session/rox-session-0.1.20.ebuild
index 831540324f12..0355bbe04931 100644
--- a/rox-base/rox-session/rox-session-0.1.20.ebuild
+++ b/rox-base/rox-session/rox-session-0.1.20.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2004 Gentoo Foundation
+# Copyright 1999-2006 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/rox-session-0.1.20.ebuild,v 1.2 2004/11/26 18:48:26 sergey Exp $
+# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/rox-session-0.1.20.ebuild,v 1.3 2006/01/18 20:36:58 vanquirius Exp $
 
 MY_PN="ROX-Session"
 DESCRIPTION="Rox-Session is a really simple session manager"
@@ -24,6 +24,6 @@ src_install() {
 	rm -rf src || die
 	dodir /usr/share/${MY_PN}
 
-	cp -rf * ${D}/usr/share/${MY_PN} || die
-	dobin ${FILESDIR}/${MY_PN} || die
+	cp -rf * "${D}"/usr/share/${MY_PN} || die
+	dobin "${FILESDIR}"/${MY_PN} || die
 }
diff --git a/rox-base/rox-session/rox-session-0.1.21.ebuild b/rox-base/rox-session/rox-session-0.1.21.ebuild
index ce1ba49522ea..b15af32fc94a 100644
--- a/rox-base/rox-session/rox-session-0.1.21.ebuild
+++ b/rox-base/rox-session/rox-session-0.1.21.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2004 Gentoo Foundation
+# Copyright 1999-2006 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/rox-session-0.1.21.ebuild,v 1.2 2004/11/26 18:48:26 sergey Exp $
+# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/rox-session-0.1.21.ebuild,v 1.3 2006/01/18 20:36:58 vanquirius Exp $
 
 MY_PN="ROX-Session"
 DESCRIPTION="Rox-Session is a really simple session manager"
@@ -24,6 +24,6 @@ src_install() {
 	rm -rf src || die
 	dodir /usr/share/${MY_PN}
 
-	cp -rf * ${D}/usr/share/${MY_PN} || die
-	dobin ${FILESDIR}/${MY_PN} || die
+	cp -rf * "${D}"/usr/share/${MY_PN} || die
+	dobin "${FILESDIR}"/${MY_PN} || die
 }
diff --git a/rox-base/rox-session/rox-session-0.26.ebuild b/rox-base/rox-session/rox-session-0.26.ebuild
index 512059a92634..f08d0e38287e 100644
--- a/rox-base/rox-session/rox-session-0.26.ebuild
+++ b/rox-base/rox-session/rox-session-0.26.ebuild
@@ -1,6 +1,8 @@
-# Copyright 1999-2005 Gentoo Foundation
+# Copyright 1999-2006 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/rox-session-0.26.ebuild,v 1.2 2005/11/19 18:33:18 svyatogor Exp $
+# $Header: /var/cvsroot/gentoo-x86/rox-base/rox-session/rox-session-0.26.ebuild,v 1.3 2006/01/18 20:36:58 vanquirius Exp $
+
+inherit rox eutils
 
 MY_PN="ROX-Session"
 DESCRIPTION="Rox-Session is a really simple session manager"
@@ -19,8 +21,6 @@ DEPEND="rox-base/rox
 APPNAME=${MY_PN}
 S="${WORKDIR}/${MY_PN}-${PV}"
 
-inherit rox eutils
-
 src_unpack() {
 	if ! built_with_use sys-apps/dbus python
 	then
@@ -29,12 +29,12 @@ src_unpack() {
 		die "python dbus modules missing"
 	fi
 	unpack ${A}
-	cd ${S}
+	cd "${S}"
 }
 
 pkg_preinst() {
 	# need to fixup some permissions
-	cd ${D}/usr/lib/rox/${APPNAME}
+	cd "${D}"/usr/lib/rox/${APPNAME}
 	chmod 0755 browser Login ROX-Session RunROX ROX-Session \
 		ROX-Session.dbg RunROX SetupPanel *.py *.py?
 	# clean up a stray directory used in the build process