aboutsummaryrefslogtreecommitdiff
path: root/cfg.mk
Commit message (Collapse)AuthorAgeFilesLines
* syntax-check: fix run.inMartin Kletzander2012-09-181-1/+1
| | | | Two more problems in "run.in" made the syntax-check fail.
* maint: fix missing spaces in messageEric Blake2012-09-121-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | I got an off-list report about a bad diagnostic: Target network card mac 52:54:00:49:07:ccdoes not match source 52:54:00:49:07:b8 True to form, I've added a syntax check rule to prevent it from recurring, and found several other offenders. * cfg.mk (sc_require_whitespace_in_translation): New rule. * src/conf/domain_conf.c (virDomainNetDefCheckABIStability): Add space. * src/esx/esx_util.c (esxUtil_ParseUri): Likewise. * src/qemu/qemu_command.c (qemuCollectPCIAddress): Likewise. * src/qemu/qemu_driver.c (qemuDomainSetMetadata) (qemuDomainGetMetadata): Likewise. * src/qemu/qemu_hotplug.c (qemuDomainChangeNetBridge): Likewise. * src/rpc/virnettlscontext.c (virNetTLSContextCheckCertDNWhitelist): Likewise. * src/vmware/vmware_driver.c (vmwareDomainResume): Likewise. * src/vbox/vbox_tmpl.c (vboxDomainGetXMLDesc, vboxAttachDrives): Avoid false negatives. * tools/virsh-domain.c (info_save_image_dumpxml): Reword. Based on a report by Luwen Su.
* Add helper library for testing the qemu monitor codeDaniel P. Berrange2012-09-071-1/+1
| | | | | | | | | | | | | To be able to test the QEMU monitor code, we need to have a fake QEMU monitor server. This introduces a simple (dumb) framework that can do this. The test case registers a series of items to be sent back as replies to commands that will be executed. A thread runs the event loop looking for incoming replies and sending back this pre-registered data. This allows testing all QEMU monitor code that deals with parsing responses and errors from QEMU, without needing QEMU around Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* maint: avoid doubled name in syntax check failuresEric Blake2012-09-051-4/+4
| | | | | | | | | | | | Based on the similar gnulib commit 96ad9077. The use of $(_sc_search_regexp) already injects $(ME) into any output messages, so a failure of these rules would look like this, pre-patch: maint.mk: maint.mk: use virStrToLong_*, not strtol variants * cfg.mk (sc_prohibit_strncmp, sc_prohibit_strtol) (sc_libvirt_unmarked_diagnostics): Drop redundant $(ME).
* build: use re-entrant functions in virshEric Blake2012-09-051-1/+1
| | | | | | | | | | | | | | | | Yesterday's commit 15d2c9f pointed out that virsh was still using localtime(), which is not thread-safe, even though virsh is definitely multi-threaded. Even if we only ever triggered it from one thread, it's better safe than sorry for maintenance purposes. * cfg.mk (exclude_file_name_regexp--sc_prohibit_nonreentrant): Tighten the rule. * tools/virsh.c (vshOutputLogFile): Avoid localtime. (vshEditWriteToTempFile, vshEditReadBackFile, cmdCd, cmdPwd) (vshCloseLogFile): Avoid strerror. * tools/console.c (vshMakeStdinRaw): Likewise. * tools/virsh-domain.c (vshGenFileName): Fix spacing in previous patch.
* maint: prohibit translations in testsuiteEric Blake2012-08-201-1/+6
| | | | | | | | | | Nothing in the testsuite or examples directory should be translated, as it is not part of the normally installed binary. We already meet this rule, but enforcing it will make it easier to remember. Suggested by Daniel P. Berrange. * cfg.mk (sc_prohibit_useless_translation): Enhance rule.
* Fix syntax-check failures wrt virshDaniel P. Berrange2012-08-201-1/+1
| | | | | * cfg.mk: Whitelist virsh.h instead of virsh.c for strcasecmp check * tools/virsh-domain.h, tools/virsh.h: Fix #define indentation
* build: fix syntax check during 'make distcheck'Eric Blake2012-08-161-1/+1
| | | | | | | | | | 'make distcheck' was failing because a syntax check file, .sc-start-sc_vulnerable_makefile_CVE-2012-3386, got left behind. I traced it to the 'distdir' rule depending on a shortcut syntax-check name rather than the full rule name normally used during 'local-check' from maint.mk. * cfg.mk (distdir): Depend on full rule, not shorthand name.
* virsh: Add helper to avoid the strcase check for virsh-*.cOsier Yang2012-08-151-1/+1
| | | | | | | | * tools/virsh.c: New macro vshStrcasecmp * tools/virsh-domain-monitor.c: Use vshStrcasecmp instead of strcasecmp * tools/virsh-snapshot.c: Likewise * cfg.mk: Only avoid doing strcase checking for virsh.c
* Turn virNetClient* into virObject instancesDaniel P. Berrange2012-08-071-3/+0
| | | | | | | Make all the virNetClient* objects use virObject APIs for reference counting Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Turn virNetServer* into virObject instancesDaniel P. Berrange2012-08-071-4/+0
| | | | | | | Make all the virNetServer* objects use the virObject APIs for reference counting Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Turn virSocket into a virObjectDaniel P. Berrange2012-08-071-1/+0
| | | | | | Make virSocket use the virObject APIs for reference counting Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Turn virNetSASLContext and virNetSASLSession into virObject instancesDaniel P. Berrange2012-08-071-2/+0
| | | | | | | Make virNetSASLContext and virNetSASLSession use virObject APIs for reference counting Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Turn virNetTLSContext and virNetTLSSession into virObject instancesDaniel P. Berrange2012-08-071-1/+0
| | | | | | | Make virNetTLSContext and virNetTLSSession use the virObject APIs for reference counting Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Add a generic reference counted virObject typeDaniel P. Berrange2012-08-071-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This introduces a fairly basic reference counted virObject type and an associated virClass type, that use atomic operations for ref counting. In a global initializer (recommended to be invoked using the virOnceInit API), a virClass type must be allocated for each object type. This requires a class name, a "dispose" callback which will be invoked to free memory associated with the object's fields, and the size in bytes of the object struct. eg, virClassPtr connclass = virClassNew("virConnect", sizeof(virConnect), virConnectDispose); The struct for the object, must include 'virObject' as its first member eg struct _virConnect { virObject object; virURIPtr uri; }; The 'dispose' callback is only responsible for freeing fields in the object, not the object itself. eg a suitable impl for the above struct would be void virConnectDispose(void *obj) { virConnectPtr conn = obj; virURIFree(conn->uri); } There is no need to reset fields to 'NULL' or '0' in the dispose callback, since the entire object will be memset to 0, and the klass pointer & magic integer fields will be poisoned with 0xDEADBEEF before being free()d When creating an instance of an object, one needs simply pass the virClassPtr eg virConnectPtr conn = virObjectNew(connclass); if (!conn) return NULL; conn->uri = virURIParse("foo:///bar") Object references can be manipulated with virObjectRef(conn) virObjectUnref(conn) The latter returns a true value, if the object has been freed (ie its ref count hit zero) Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Remove tabs from all perl files & enforce thisDaniel P. Berrange2012-07-301-1/+1
| | | | | | The cfg.mk file rule to check for tab characters was not applied to perl files. Much of our Perl code is full of tabs as a result. Kill them, kill them all !
* maint: avoid regression on copyright listingsEric Blake2012-07-271-1/+12
| | | | | | | | | | | | | | | | | | | | | | | Commit f9ce7dad6 tried to kill uses of a raw street address, but missed a few instances. Automate things so we don't introduce new problems in the future. * cfg.mk (sc_copyright_address): New rule. (exclude_file_name_regexp--sc_copyright_address): Add exemption. * bootstrap.conf: Adjust offenders. * build-aux/augeas-gentest.pl: Likewise. * examples/systemtap/events.stp: Likewise. * examples/systemtap/qemu-monitor.stp: Likewise. * examples/systemtap/rpc-monitor.stp: Likewise. * src/dtrace2systemtap.pl: Likewise. * src/esx/esx_vi_generator.py: Likewise. * src/hyperv/hyperv_wmi_generator.py: Likewise. * src/remote/qemu_protocol.x: Likewise. * src/remote/remote_protocol.x: Likewise. * src/rpc/gensystemtap.pl: Likewise. * src/rpc/virnetprotocol.x: Likewise. * tests/object-locking.ml: Likewise. * tools/virt-xml-validate.in: Likewise.
* maint: don't permit format strings without %Eric Blake2012-07-261-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Any time we have a string with no % passed through gettext, a translator can inject a % to cause a stack overread. When there is nothing to format, it's easier to ask for a string that cannot be used as a formatter, by using a trivial "%s" format instead. In the past, we have used --disable-nls to catch some of the offenders, but that doesn't get run very often, and many more uses have crept in. Syntax check to the rescue! The syntax check can catch uses such as virReportError(code, _("split " "string")); by using a sed script to fold context lines into one pattern space before checking for a string without %. This patch is just mechanical insertion of %s; there are probably several messages touched by this patch where we would be better off giving the user more information than a fixed string. * cfg.mk (sc_prohibit_diagnostic_without_format): New rule. * src/datatypes.c (virUnrefConnect, virGetDomain) (virUnrefDomain, virGetNetwork, virUnrefNetwork, virGetInterface) (virUnrefInterface, virGetStoragePool, virUnrefStoragePool) (virGetStorageVol, virUnrefStorageVol, virGetNodeDevice) (virGetSecret, virUnrefSecret, virGetNWFilter, virUnrefNWFilter) (virGetDomainSnapshot, virUnrefDomainSnapshot): Add %s wrapper. * src/lxc/lxc_driver.c (lxcDomainSetBlkioParameters) (lxcDomainGetBlkioParameters): Likewise. * src/conf/domain_conf.c (virSecurityDeviceLabelDefParseXML) (virDomainDiskDefParseXML, virDomainGraphicsDefParseXML): Likewise. * src/conf/network_conf.c (virNetworkDNSHostsDefParseXML) (virNetworkDefParseXML): Likewise. * src/conf/nwfilter_conf.c (virNWFilterIsValidChainName): Likewise. * src/conf/nwfilter_params.c (virNWFilterVarValueCreateSimple) (virNWFilterVarAccessParse): Likewise. * src/libvirt.c (virDomainSave, virDomainSaveFlags) (virDomainRestore, virDomainRestoreFlags) (virDomainSaveImageGetXMLDesc, virDomainSaveImageDefineXML) (virDomainCoreDump, virDomainGetXMLDesc) (virDomainMigrateVersion1, virDomainMigrateVersion2) (virDomainMigrateVersion3, virDomainMigrate, virDomainMigrate2) (virStreamSendAll, virStreamRecvAll) (virDomainSnapshotGetXMLDesc): Likewise. * src/nwfilter/nwfilter_dhcpsnoop.c (virNWFilterSnoopReqLeaseDel) (virNWFilterDHCPSnoopReq): Likewise. * src/openvz/openvz_driver.c (openvzUpdateDevice): Likewise. * src/openvz/openvz_util.c (openvzKBPerPages): Likewise. * src/qemu/qemu_cgroup.c (qemuSetupCgroup): Likewise. * src/qemu/qemu_command.c (qemuBuildHubDevStr, qemuBuildChrChardevStr) (qemuBuildCommandLine): Likewise. * src/qemu/qemu_driver.c (qemuDomainGetPercpuStats): Likewise. * src/qemu/qemu_hotplug.c (qemuDomainAttachNetDevice): Likewise. * src/rpc/virnetsaslcontext.c (virNetSASLSessionGetIdentity): Likewise. * src/rpc/virnetsocket.c (virNetSocketNewConnectUNIX) (virNetSocketSendFD, virNetSocketRecvFD): Likewise. * src/storage/storage_backend_disk.c (virStorageBackendDiskBuildPool): Likewise. * src/storage/storage_backend_fs.c (virStorageBackendFileSystemProbe) (virStorageBackendFileSystemBuild): Likewise. * src/storage/storage_backend_rbd.c (virStorageBackendRBDOpenRADOSConn): Likewise. * src/storage/storage_driver.c (storageVolumeResize): Likewise. * src/test/test_driver.c (testInterfaceChangeBegin) (testInterfaceChangeCommit, testInterfaceChangeRollback): Likewise. * src/vbox/vbox_tmpl.c (vboxListAllDomains): Likewise. * src/xenxs/xen_sxpr.c (xenFormatSxprDisk, xenFormatSxpr): Likewise. * src/xenxs/xen_xm.c (xenXMConfigGetUUID, xenFormatXMDisk) (xenFormatXM): Likewise.
* maint: avoid empty regex in syntax checkerEric Blake2012-07-261-1/+1
| | | | | | | | | | | | We were defining 'func_or' as '|VIR_ERROR|...', which when put inside 'func_re' resulted in a regex that matches everything in isolation. Thankfully, we always used func_re with a leading anchor \<, and since the empty regex does not start a word, we happened to get the result we wanted; but it's better to define func_or without a leading space converted into a leading empty alternation. * cfg.mk (func_or): Strip leading space.
* build: update to latest gnulib, for secure tarballEric Blake2012-07-261-0/+11
| | | | | | | | | | | | | | Pick up some build fixes in the latest gnulib. In particular, we want to ensure that official tarballs are secure, but don't want to penalize people who don't run 'make dist', since fixed automake still hasn't hit common platforms like Fedora 17. * .gnulib: Update to latest, for Automake CVE-2012-3386 detection. * bootstrap: Resync from gnulib. * bootstrap.conf (gnulib_extra_files): Drop missing, since gnulib has dropped it in favor of Automake's version. * cfg.mk (local-checks-to-skip): Conditionally skip the security check in cases where it doesn't matter.
* virsh: Split cmds in node device group from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | Commands in node device group moved from virsh.c to virsh-nodedev.c, * virsh.c: Remove commands in node device group. * virsh-nodedev.c: New file, filled with commands in node device group * po/POTFILES.in: Add virsh-nodedev.c * cfg.mk: Skip to check config.h including for virsh-nodedev.c
* virsh: Split cmds in host group from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | Commands in host group moved from virsh.c to virsh-host.c, * virsh.c: Remove commands in host group. * virsh-host.c: New file, filled with commands in host group * po/POTFILES.in: Add virsh-host.c * cfg.mk: Skip to check config.h including for virsh-host.c
* virsh: Split cmds to manage domain snapshot from virsh.cOsier Yang2012-07-261-2/+2
| | | | | | | | | | | Commands to manage domain snapshot are moved from virsh.c to virsh-snapshot.c. * virsh.c: Remove domain snapshot commands. * virsh-snapshot.c: New file, filled with domain snapshot commands. * po/POTFILES.in: Add virsh-snapshot.c * cfg.mk: Skip strcase and config.h including checking for virsh-snapshot.c
* virsh: Split cmds to manage secret from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | | | Commands to manage secret are moved from virsh.c to virsh-secret.c, with a few helpers for secret command use. * virsh.c: Remove secret commands and a few helpers. (vshCommandOptSecret, and vshCommandOptSecretBy) * virsh-secret.c: New file, filled with secret commands and its helpers. * po/POTFILES.in: Add virsh-secret.c * cfg.mk: Skip to check config.h including for virsh-secret.c
* virsh: Split cmds to manage network filter from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | | | | | Commands to manage network filter are moved from virsh.c to virsh-nwfilter.c, with a few helpers for network filter command use. * virsh.c: Remove network filter commands and a few helpers. (vshCommandOptNWFilter, and vshCommandOptNWFilterBy) * virsh-nwfilter.c: New file, filled with network filter commands and its helpers. * po/POTFILES.in: Add virsh-nwfilter.c * cfg.mk: Skip to check config.h including for virsh-nwfilter.c
* virsh: Split cmds to manage host interface from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | | | | Commands to manage host interface are moved from virsh.c to virsh-interface.c, with a few helpers for interface command use. * virsh.c: Remove interface commands and a few helpers. (vshCommandOptInterface, vshCommandOptInterfaceBy) * virsh-interface.c: New file, filled with interface commands and its helpers. * cfg.mk: Skip to check config.h including for virsh-interface.c * po/POTFILES.in: Add virsh-interface.c
* virsh: Split cmds to manage network from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | | | Commands to manage network are moved from virsh.c to virsh-network.c, with a few helpers for network command use. * virsh.c: Remove network commands and a few helpers. * virsh-network.c: New file, filled with network commands and its helpers. * po/POTFILES.in: Add virsh-network.c * cfg.mk: Skip to check config.h including for virsh-network.c
* virsh: Split cmds of storage pool group from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | | | | | | | | | | | | This splits commands of storage pool group into virsh-pool.c, The helpers not for common use are moved too. Standard copyright is added for the new file. * tools/virsh.c: Remove commands for storage storage pool and a few helpers. (vshCommandOptVol, vshCommandOptVolBy). * tools/virsh-pool.c: New file, filled with commands of storage pool group and its helpers. * po/POTFILES.in: Add virsh-pool.c * cfg.mk: Skip to check config.h including for virsh-pool.c
* virsh: Split cmds of storage volume group from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | | | | | | | | | | | | This splits commands of storage volume group into virsh-volume.c, The helpers not for common use are moved too. Standard copyright is added for the new file. * tools/virsh.c: Remove commands for storage storage volume and a few helpers. (vshCommandOptVol, vshCommandOptVolBy). * tools/virsh-volume.c: New file, filled with commands of storage volume group and its helpers. * po/POTFILES.in: Add virsh-volume.c * cfg.mk: Skip to check config.h including for virsh-volume.c
* virsh: Split cmds of domain group from virsh.cOsier Yang2012-07-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | This splits commands to manage domain into virsh-domain.c,The helpers not for common use are moved into them too. Standard copyright is added for the new file. * tools/virsh.c: - Remove commands for domain group, and one helper (vshDomainVcpuStateToString) - vshStreamSink is moved before commands's definition for it's also used by commands not of domain group, such as volUpload. * tools/virsh-domain.c: - New file, commands for domain group and the one helper are moved into it. * po/POTFILES.in: - Add virsh-domain.c * cfg.mk: - Skip to check config.h including for virsh-domain.c
* virsh: Split cmds for domain monitoring from virsh.cOsier Yang2012-07-261-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | This splits commands commands to monitor domain status into virsh-domain-monitor.c. The helpers not for common use are moved too. Standard copyright is added. * tools/virsh.c: - Remove commands for domain monitoring group and a few helpers ( vshDomainIOErrorToString, vshGetDomainDescription, vshDomainControlStateToString, vshDomainStateToString) not for common use. - Remove (incldue "intprops.h"). * tools/virsh-domain-monitor.c: - New file, filled with commands of domain monitor group. - Add "intprops.h". * cfg.mk: - Skip strcase checking for virsh-domain-monitor.c - Skip to check config.h including for virsh-domain-monitor.c * po/POTFILES.in - Add virsh-domain-monitor.c
* Replace use of custom macros with virReportError in the Xen driversDaniel P. Berrange2012-07-201-7/+0
| | | | | | | | Update the legacy Xen drivers to use virReportError instead of the statsError, virXenInotifyError, virXenStoreError, virXendError, xenUnifiedError, xenXMError custom macros Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of VMX_ERROR with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the VMX shared code to use virReportError instead of the VMX_ERROR custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of virConfError with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the libvirtd config handling code to use virReportError instead of the virConfError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of nodeReportError with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the nodeinfo helper code to use virReportError instead of the nodeReportError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of virSecurityReportError with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the security drivers to use virReportError instead of the virSecurityReportError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of PHYP_ERROR with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the Power-Hypervisor driver to use virReportError instead of the PHYP_ERROR custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of HYPERV_ERROR with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the Hyper-V driver to use virReportError instead of the HYPERV_ERROR custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of ESX_ERROR & ESX_VI_ERROR with virReportErrorDaniel P. Berrange2012-07-201-2/+0
| | | | | | | Update the ESX driver to use virReportError instead of the ESX_ERROR & ESX_VI_ERROR custom macros Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of libxlError with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the libxl driver to use virReportError instead of the libxlError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of streamsReportError with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the streams code to use virReportError instead of the streamsReportError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of remoteError with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the remote driver to use virReportError instead of the remoteError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of XENXS_ERROR with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the XenXS shared code to use virReportError instead of the XENXS_ERROR custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of openvzError with virReportErrorDaniel P. Berrange2012-07-201-1/+0
| | | | | | | Update the OpenVZ driver to use virReportError instead of the openvzError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Fix Xen driver to have sensible error messagesDaniel P. Berrange2012-07-201-1/+1
| | | | | | | | The Xen driver had a number of error reports which passed a constant string without format specifiers and was missing "%s". Furthermore the errors were related to failing system calls, but virReportSystemError was not used. So the only useful piece of info (the errno) was being discarded
* Replace use of vmwareError with virReportErrorDaniel P. Berrange2012-07-191-1/+0
| | | | | | | Update the VMWare driver to use virReportError instead of the vmwareError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of virCPUReportError with virReportErrorDaniel P. Berrange2012-07-191-1/+0
| | | | | | | Update the CPU helper APIs to use virReportError instead of the virCPUReportError custom macor Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of vboxError with virReportErrorDaniel P. Berrange2012-07-191-1/+0
| | | | | | | Update the VirtualBox driver to use virReportError instead of the vboxError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of qemuReportError with virReportErrorDaniel P. Berrange2012-07-191-1/+0
| | | | | | | Update the QEMU driver to use virReportError instead of the qemuReportError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Replace use of umlReportError with virReportErrorDaniel P. Berrange2012-07-191-1/+0
| | | | | | | Update the UML driver to use virReportError instead of the umlReportError custom macro Signed-off-by: Daniel P. Berrange <berrange@redhat.com>