diff options
| author |   H.J. Lu <hjl.tools@gmail.com> | 2022-08-01 16:02:39 -0700 |
|---|---|---|
| committer |   Andreas K. Hüttel <dilfridge@gentoo.org> | 2022-10-08 16:39:50 +0200 |
| commit | 83894445e8a11a1053fe806012de3cf8bcb7c2b3 (patch) | |
| tree | a47eaa71137719470a127313ab1493e0e1edd298 | |
| parent | Re: PowerPC64 pcrel got relocs against local symbols (diff) | |
| download | binutils-gdb-83894445e8a11a1053fe806012de3cf8bcb7c2b3.tar.gz binutils-gdb-83894445e8a11a1053fe806012de3cf8bcb7c2b3.tar.bz2 binutils-gdb-83894445e8a11a1053fe806012de3cf8bcb7c2b3.zip | |
elf: Reset alignment for each PT_LOAD segment
Reset alignment for each PT_LOAD segment to avoid using alignment from
the previous PT_LOAD segment.
bfd/
PR ld/29435
* elf.c (assign_file_positions_for_load_sections): Reset
alignment for each PT_LOAD segment.
ld/
PR ld/29435
* testsuite/ld-elf/pr29435.d: New file.
* testsuite/ld-elf/pr29435.s: Likewise.
(cherry picked from commit 59f214544c50ec7ebbca285ff2b4949f48671690)
(cherry picked from commit a98316d5cf970cbc99689797d84c2ea832bcdcbb)
| -rw-r--r-- | bfd/elf.c | 7 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr29435.d | 11 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/pr29435.s | 6 |
3 files changed, 21 insertions, 3 deletions
diff --git a/bfd/elf.c b/bfd/elf.c index 89484ceb233..8bd572d712e 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -5438,8 +5438,6 @@ assign_file_positions_for_load_sections (bfd *abfd, Elf_Internal_Phdr *p; file_ptr off; /* Octets. */ bfd_size_type maxpagesize; - bfd_size_type p_align; - bool p_align_p = false; unsigned int alloc, actual; unsigned int i, j; struct elf_segment_map **sorted_seg_map; @@ -5524,7 +5522,6 @@ assign_file_positions_for_load_sections (bfd *abfd, qsort (sorted_seg_map, alloc, sizeof (*sorted_seg_map), elf_sort_segments); - p_align = bed->p_align; maxpagesize = 1; if ((abfd->flags & D_PAGED) != 0) { @@ -5559,6 +5556,8 @@ assign_file_positions_for_load_sections (bfd *abfd, asection **secpp; bfd_vma off_adjust; /* Octets. */ bool no_contents; + bfd_size_type p_align; + bool p_align_p; /* An ELF segment (described by Elf_Internal_Phdr) may contain a number of sections with contents contributing to both p_filesz @@ -5569,6 +5568,8 @@ assign_file_positions_for_load_sections (bfd *abfd, p = phdrs + m->idx; p->p_type = m->p_type; p->p_flags = m->p_flags; + p_align = bed->p_align; + p_align_p = false; if (m->count == 0) p->p_vaddr = m->p_vaddr_offset * opb; diff --git a/ld/testsuite/ld-elf/pr29435.d b/ld/testsuite/ld-elf/pr29435.d new file mode 100644 index 00000000000..4ca4fd086a2 --- /dev/null +++ b/ld/testsuite/ld-elf/pr29435.d @@ -0,0 +1,11 @@ +#ld: -shared -z separate-code -z relro +#xfail: ![check_shared_lib_support] +#xfail: ![check_relro_support] +#readelf: -Wl + +#failif +#... + +LOAD +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ .* 0x8000 +#... + +LOAD +0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ 0x[0-9a-f]+ .* 0x8000 +#... diff --git a/ld/testsuite/ld-elf/pr29435.s b/ld/testsuite/ld-elf/pr29435.s new file mode 100644 index 00000000000..d2d8f265f5e --- /dev/null +++ b/ld/testsuite/ld-elf/pr29435.s @@ -0,0 +1,6 @@ + .text + .balign 0x8000 + .globl foo + .type foo, %function +foo: + .byte 0 |